Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging for closing partition channels - partition and topic misplaced #977

Merged
merged 1 commit into from
Oct 28, 2024
+4 −4
Merged

Fix logging for closing partition channels - partition and topic misplaced #977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/main/java/com/snowflake/kafka/connector/internal/streaming/SnowflakeSinkServiceV2.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,8 +516,8 @@ private void closeSequentially(Collection<TopicPartition> partitions) {
LOGGER.info(
"Closing partitionChannel:{}, partition:{}, topic:{}",
topicPartitionChannel == null ? null : topicPartitionChannel.getChannelNameFormatV1(),
topicPartition.topic(),
topicPartition.partition());
topicPartition.partition(),
topicPartition.topic());
partitionsToChannel.remove(partitionChannelKey);
});
}
Expand All @@ -537,8 +537,8 @@ private CompletableFuture<Void> closeTopicPartition(TopicPartition topicPartitio
LOGGER.info(
"Closing partitionChannel:{}, partition:{}, topic:{}",
topicPartitionChannel == null ? null : topicPartitionChannel.getChannelNameFormatV1(),
topicPartition.topic(),
topicPartition.partition());
topicPartition.partition(),
topicPartition.topic());

// It's possible that some partitions can be unassigned before their respective channels are
// even created.
Expand Down
Loading