Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging for closing partition channels - partition and topic misplaced #977

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Fix logging for closing partition channels - partition and topic misplaced #977

merged 1 commit into from
Oct 28, 2024

Conversation

sfc-gh-achyzy
Copy link
Contributor

Overview

NO-SNOW

Fix logging for closing partition channels - partition and topic misplaced

Pre-review checklist

  • This change should be part of a Behavior Change Release. See go/behavior-change.
  • This change has passed Merge gate tests
  • Snowpipe Changes
  • Snowpipe Streaming Changes
  • This change is TEST-ONLY
  • This change is README/Javadocs only
  • This change is protected by a config parameter <PARAMETER_NAME> eg snowflake.ingestion.method.
    • Yes - Added end to end and Unit Tests.
    • No - Suggest why it is not param protected
  • Is his change protected by parameter <PARAMETER_NAME> on the server side?
    • The parameter/feature is not yet active in production (partial rollout or PrPr, see Changes for Unreleased Features and Fixes).
    • If there is an issue, it can be safely mitigated by turning the parameter off. This is also verified by a test (See go/ppp).

@sfc-gh-achyzy sfc-gh-achyzy requested a review from a team as a code owner October 26, 2024 10:16
@sfc-gh-mbobowski sfc-gh-mbobowski merged commit ad49fe6 into master Oct 28, 2024
54 checks passed
@sfc-gh-mbobowski sfc-gh-mbobowski deleted the achyzy-NO-SNOW-fix-logging-for-closing-partition-channels branch October 28, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-gjachimko sfc-gh-gjachimko sfc-gh-gjachimko approved these changes

@sfc-gh-mbobowski sfc-gh-mbobowski sfc-gh-mbobowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-achyzy @sfc-gh-mbobowski @sfc-gh-gjachimko