Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-913746 upgrade jdbc 3.14.3 #745

Merged
merged 2 commits into from
Nov 15, 2023
Merged

SNOW-913746 upgrade jdbc 3.14.3 #745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03d498e
Fix failing test due to JDBC NPE in 3.14.3
sfc-gh-japatel Nov 10, 2023
25a3205
SNOW-913746 Upgrade JDBC to 3.14.3 for using useS3regionalURL
sfc-gh-japatel Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@
<dependency>
<groupId>net.snowflake</groupId>
<artifactId>snowflake-jdbc</artifactId>
<version>3.13.30</version>
<version>3.14.3</version>
</dependency>

<!-- Ingest SDK for copy staged file into snowflake table -->
Expand Down
2 changes: 1 addition & 1 deletion pom_confluent.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@
<dependency>
<groupId>net.snowflake</groupId>
<artifactId>snowflake-jdbc</artifactId>
<version>3.13.30</version>
<version>3.14.3</version>
</dependency>

<!-- Ingest SDK for copy staged file into snowflake table -->
Expand Down
3 changes: 3 additions & 0 deletions src/main/java/com/snowflake/kafka/connector/internal/InternalUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,9 @@ protected static Properties generateProxyParametersIfRequired(Map<String, String
proxyProperties.put(SFSessionProperty.PROXY_USER.getPropertyKey(), username);
proxyProperties.put(SFSessionProperty.PROXY_PASSWORD.getPropertyKey(), password);
}
// There is a change in JDBC version 3.13.31 which causes NPE if this is not added.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a JIRA created for the owner to fix this? We shouldn't have this assumption, this is a behavior change

Copy link
Collaborator Author

@sfc-gh-japatel sfc-gh-japatel Nov 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will create a issue on JDBC.
Since we have a workaround, its okay to add this here but I agree it should be fixed by JDBC.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened a PR in JDBC: snowflakedb/snowflake-jdbc#1559

// https://github.com/snowflakedb/snowflake-jdbc/blob/master/src/main/java/net/snowflake/client/jdbc/SnowflakeUtil.java#L614
proxyProperties.put(SFSessionProperty.GZIP_DISABLED.getPropertyKey(), "false");
}
return proxyProperties;
}
Expand Down
2 changes: 2 additions & 0 deletions src/test/java/com/snowflake/kafka/connector/internal/InternalStageIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,8 @@ public void testInternalStageWithProxy() throws SnowflakeSQLException {
proxyProperties.put(SFSessionProperty.PROXY_PORT.getPropertyKey(), "3128");
proxyProperties.put(SFSessionProperty.PROXY_USER.getPropertyKey(), "admin");
proxyProperties.put(SFSessionProperty.PROXY_PASSWORD.getPropertyKey(), "test");
// required otherwise JDBC version 3.13.31 throws NPE
proxyProperties.put(SFSessionProperty.GZIP_DISABLED.getPropertyKey(), "false");

// Create new snowflake connection service
Map<String, String> config = TestUtils.getConf();
Expand Down
Loading