SNOW-913746 upgrade jdbc 3.14.3 #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-japatel
requested review from
sfc-gh-tzhang,
sfc-gh-tjones,
sfc-gh-rcheng and
a team
as code owners
sfc-gh-tzhang
approved these changes
Nov 13, 2023
| @@ -299,6 +299,9 @@ protected static Properties generateProxyParametersIfRequired(Map<String, String | |||
| proxyProperties.put(SFSessionProperty.PROXY_USER.getPropertyKey(), username); | |||
| proxyProperties.put(SFSessionProperty.PROXY_PASSWORD.getPropertyKey(), password); | |||
| } | |||
| // There is a change in JDBC version 3.13.31 which causes NPE if this is not added. | |||
There was a problem hiding this comment.
Do we have a JIRA created for the owner to fix this? We shouldn't have this assumption, this is a behavior change
There was a problem hiding this comment.
Will create a issue on JDBC.
Since we have a workaround, its okay to add this here but I agree it should be fixed by JDBC.
There was a problem hiding this comment.
Opened a PR in JDBC: snowflakedb/snowflake-jdbc#1559
|
@sfc-gh-jfan snyk is not running can you check please? thanks |
sfc-gh-japatel
changed the title
sfc-gh-japatel
deleted the
japatel-SNOW-913746-upgrade-jdbc-3-14-3-main
branch
khsoneji
pushed a commit
to confluentinc/snowflake-kafka-connector
that referenced
this pull request
Dec 4, 2023
khsoneji
pushed a commit
to confluentinc/snowflake-kafka-connector
that referenced
this pull request
Dec 4, 2023
khsoneji
pushed a commit
to confluentinc/snowflake-kafka-connector
that referenced
this pull request
Dec 4, 2023
EduardHantig
pushed a commit
to streamkap-com/snowflake-kafka-connector
that referenced
this pull request
Feb 1, 2024
sudeshwasnik
pushed a commit
to confluentinc/snowflake-kafka-connector
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade JDBC to 3.14.3.
Modify some tests since v3.13.31 is throwing NPE.