Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/unification artifacts fixes after rebase #1921

Closed
wants to merge 5 commits into from
+5,821 −2,576
Closed

Features/unification artifacts fixes after rebase #1921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
82bef1d
Added glob support for snowpark and streamlit (#1862)
sfc-gh-astus Nov 18, 2024
78ecab7
Fix broken v1 to v2 test on the feature branch (#1876)
sfc-gh-bdufour Nov 21, 2024
63063d4
Moved native app artifacts logic to common API (#1877)
sfc-gh-bdufour Nov 25, 2024
d181eb7
Move PathMapping and ProcessorMapping out of native app logic (#1899)
sfc-gh-bdufour Nov 27, 2024
1748f3d
Fixed precommit errors and tests
sfc-gh-astus Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,14 @@
**/__snapshots__/ @snowflakedb/snowcli @snowflakedb/nade
**/test_data @snowflakedb/snowcli @snowflakedb/nade
**/testing_utils/ @snowflakedb/snowcli @snowflakedb/nade
src/snowflake/cli/api/artifacts/ @snowflakedb/snowcli @snowflakedb/nade
src/snowflake/cli/api/metrics.py @snowflakedb/snowcli @snowflakedb/nade
src/snowflake/cli/api/project/definition_conversion.py @snowflakedb/snowcli @snowflakedb/nade
src/snowflake/cli/api/utils/ @snowflakedb/snowcli @snowflakedb/nade
tests/api/artifacts/ @snowflakedb/snowcli @snowflakedb/nade
tests/api/metrics/ @snowflakedb/snowcli @snowflakedb/nade
tests/api/test_metrics.py @snowflakedb/snowcli @snowflakedb/nade
tests/api/utils/ @snowflakedb/snowcli @snowflakedb/nade
tests_common/__init__.py @snowflakedb/snowcli @snowflakedb/nade
tests_common/conftest.py @snowflakedb/snowcli @snowflakedb/nade
tests_common/deflake.py @snowflakedb/snowcli @snowflakedb/nade
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ jobs:
with:
python-version: '3.x'
- name: Install pre-commit
run: python -m pip install pre-commit tomlkit
run: python -m pip install pre-commit tomlkit ruff==0.1.7
- name: Ruff
run: ruff check --exclude "**/tests_common/,**/tests_integration/"
- name: Run pre-commit
run: pre-commit run --all-files
5 changes: 5 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ repos:
hooks:
- id: ruff
args: [--fix, --exclude, "**/tests_common/,**/tests_integration/"]
verbose: true
- repo: https://github.com/psf/black
rev: 22.12.0
hooks:
Expand All @@ -25,6 +26,10 @@ repos:
hooks:
- id: mypy
additional_dependencies: [types-pkg-resources==0.1.3, types-all==1.0.0]
exclude: >
(?x)
^tests/test_data/projects/.*|
^tests_integration/test_data/projects/.*
- repo: https://github.com/codespell-project/codespell
rev: v2.2.4
hooks:
Expand Down
2 changes: 2 additions & 0 deletions RELEASE-NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@
* `--follow`: Stream logs in real-time.
* `--follow-interval`: Set custom polling intervals during log streaming.
* `snow connection add` supports `--no-interactive` flag to skip interactive prompts.
* Added support for glob pattern in artifact paths in snowflake.yml for Streamlit.
* Added support for glob pattern in artifact paths in snowflake.yml for Snowpark, requires ENABLE_SNOWPARK_GLOB_SUPPORT feature flag.

## Fixes and improvements
* `snow --info` callback returns information about `SNOWFLAKE_HOME` variable.
Expand Down
Loading
Loading