Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/unification artifacts fixes after rebase #1921

Closed
wants to merge 5 commits into from
Closed

Features/unification artifacts fixes after rebase #1921

wants to merge 5 commits into from

Conversation

sfc-gh-astus
Copy link
Contributor

@sfc-gh-astus sfc-gh-astus commented Dec 4, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Fixed precommit errors and tests after rebase.

sfc-gh-astus and others added 4 commits December 4, 2024 17:42
@sfc-gh-astus
Added glob support for snowpark and streamlit (#1862)
82bef1d 
* Added glob support for Snowpark and Streamlit

* Added glob support for Snowpark and Streamlit

* Added glob support for Snowpark and Streamlit

* Changed PathMapping.src to Path

* Changes after review

* Changes after review 2

* Revert "Changed PathMapping.src to Path"

This reverts commit 3eb543d.

* Changes after review 3

* Changes after review 4

* Added full global support

* Renamed feature flag and added release notes

* Removed or None
@sfc-gh-bdufour @sfc-gh-astus
Fix broken v1 to v2 test on the feature branch (#1876)
78ecab7
@sfc-gh-bdufour @sfc-gh-astus
Moved native app artifacts logic to common API (#1877)
63063d4
@sfc-gh-bdufour @sfc-gh-astus
Move PathMapping and ProcessorMapping out of native app logic (#1899)
d181eb7
@sfc-gh-astus sfc-gh-astus requested review from a team as code owners December 4, 2024 17:51
@sfc-gh-astus sfc-gh-astus force-pushed the features/unification-artifacts-fixes-after-rebase branch from 3485cf3 to debf07f Compare December 4, 2024 17:52
sfc-gh-bdufour
sfc-gh-bdufour approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-bdufour sfc-gh-bdufour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for NADE

@sfc-gh-astus sfc-gh-astus force-pushed the features/unification-artifacts-fixes-after-rebase branch 9 times, most recently from 30cb861 to 5caad17 Compare December 5, 2024 13:41
@sfc-gh-astus sfc-gh-astus force-pushed the features/unification-artifacts-fixes-after-rebase branch from 7b309c3 to 1748f3d Compare December 6, 2024 14:10
@sfc-gh-bdufour sfc-gh-bdufour force-pushed the features/unification-artifacts branch from d181eb7 to fe16b12 Compare December 6, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-bdufour sfc-gh-bdufour sfc-gh-bdufour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-astus @sfc-gh-bdufour