Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-911238: Add WithOriginalTimestamp context switch #918

Merged
merged 5 commits into from
Oct 10, 2023
Merged

SNOW-911238: Add WithOriginalTimestamp context switch #918

merged 5 commits into from
Oct 10, 2023

Conversation

sfc-gh-dstempniak
Copy link
Collaborator

Description

Add WithOriginalTimestamp context switch.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-dstempniak sfc-gh-dstempniak requested a review from a team as a code owner October 1, 2023 20:41
@sfc-gh-dstempniak sfc-gh-dstempniak force-pushed the SNOW-911238-timestamp-overflow branch from 61c19fa to 3c6fbfc Compare October 1, 2023 20:43
This was referenced Oct 2, 2023
Closed
Closed
sfc-gh-pfus
sfc-gh-pfus reviewed Oct 3, 2023
View reviewed changes
arrow_chunk.go Outdated Show resolved Hide resolved
arrow_chunk.go Outdated Show resolved Hide resolved
cmd/arrow/batches/arrow_batches.go Outdated Show resolved Hide resolved
cmd/arrow/batches/arrow_batches.go Outdated Show resolved Hide resolved
cmd/arrow/batches/arrow_batches.go Outdated Show resolved Hide resolved
converter_test.go Show resolved Hide resolved
converter_test.go Outdated Show resolved Hide resolved
converter_test.go Outdated Show resolved Hide resolved
converter_test.go Outdated Show resolved Hide resolved
converter_test.go Outdated Show resolved Hide resolved
sfc-gh-pfus
sfc-gh-pfus reviewed Oct 5, 2023
View reviewed changes
converter.go Outdated Show resolved Hide resolved
converter.go Show resolved Hide resolved
converter.go Show resolved Hide resolved
converter.go Show resolved Hide resolved
@sfc-gh-igarish
Copy link
Collaborator

sfc-gh-igarish commented Oct 6, 2023 •
edited
Loading

Do we have test coverage for original ask in JIRA? i.e. "change year to >= 2263 or <= 1677 and the the unit test will fail". Otherwise LGTM.

@sfc-gh-dstempniak
Copy link
Collaborator Author

@sfc-gh-igarish We have tests for "strange" timestamps here:

gosnowflake/converter_test.go

Line 1645 in 3657f94

func TestTimestampConversionWithArrowBatchesFailsForDistantDates(t *testing.T) {

And positive path (after fix) here:

gosnowflake/converter_test.go

Line 1682 in 3657f94

func TestTimestampConversionWithArrowBatchesAndWithOriginalTimestamp(t *testing.T) {

@sfc-gh-dstempniak sfc-gh-dstempniak force-pushed the SNOW-911238-timestamp-overflow branch from 3657f94 to d47fae8 Compare October 10, 2023 08:46
@sfc-gh-dstempniak sfc-gh-dstempniak merged commit 3a29554 into master Oct 10, 2023
21 checks passed
@sfc-gh-dstempniak sfc-gh-dstempniak deleted the SNOW-911238-timestamp-overflow branch October 10, 2023 09:58
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-dstempniak @sfc-gh-igarish @sfc-gh-pfus