-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arrowToRecord() produce wrong timestamp for some future dates #910
Comments
hi and thank you for submitting this issue with us, we'll take a look |
PR #918 with the fix in progress. Thank you for bearing with us while this is getting fixed ! |
PR merged and will be part of the October release, expected towards the end of October |
gosnowflake 1.7.0 released with the fix, thank you all for bearing with us ! |
Hello, I am wondering if there are any recommendations on how |
hi there - we seem to have some in converter_test.go; would that suffice as an example or should we provide something more ? |
@sfc-gh-dszmolka Thank you, this is helpful. One more question: |
we'll check @Yifeng-Sigma , started a discussion on that. |
Super easy to reproduce,
https://github.com/sigmacomputing/gosnowflake/blob/17fd0144860b6ee0164c398488ad9fa02fb65f36/converter_test.go#L850
change year to >= 2263 or <= 1677 and the the unit test will fail.
While per documentation it's within the range "Snowflake recommends using years between 1582 and 9999".
The text was updated successfully, but these errors were encountered: