fix: correct token bucket delays when experiencing system time jumps #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
aajtodd
approved these changes
Feb 23, 2023
| */ | ||
| public class StandardRetryTokenBucket( | ||
| @OptIn(ExperimentalTime::class) |
There was a problem hiding this comment.
We've gotten ourselves in trouble in the past by using experimental stdlib features (awslabs/aws-sdk-kotlin#622, awslabs/aws-sdk-kotlin#736). I don't have a better suggestion here but something to consider w.r.t any versioning policy/strategy we define.
There was a problem hiding this comment.
Discussed offline and decided to keep usage of this type for now, despite it being marked as experimental. I've added a task aws-sdk-kotlin#860 to track revisiting all usages of experimental/unstable APIs before GA.
lauzadis
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Closes #805
Description of changes
As noted in #805 the retry token bucket calculation is susceptible to changes in system time. Replace the
Clockimplementation with a KotlinTimeSource.Monotonic, which offers intra-moment comparison capable of withstanding system time changes.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.