Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update runtime-core API manifest after API-incompatible change that wasn't caught by CI #811

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

ianbotsf
Copy link
Contributor

Issue #

(none)

Description of changes

#810 changed the API signature for the public constructor StandardRetryTokenBucket. It was introduced on a separate branch from the change that added API compatibility verification, #808, and so did not fail compatibility checks in PR. The push to main occurred after API compatibility verification was enabled and wasn't blocked on merging because no overlapping files were touched.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ianbotsf ianbotsf added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Feb 23, 2023
@ianbotsf ianbotsf requested a review from a team as a code owner February 23, 2023 17:44
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ianbotsf ianbotsf merged commit 55be83a into main Feb 23, 2023
@ianbotsf ianbotsf deleted the fix-update-api-manifest branch February 23, 2023 18:10
aajtodd pushed a commit that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants