-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Candidate v2.51.0 #1196
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapping CLKOUT1 to userClk, which is a useful optional clock reference
adding userCLk to SelectioDeserUltraScale.vhd
### Description - Using "std_logic" instead of "sl" for generics due to issues with SystemVerilog handling VHDL subtype on generics properly
Update RstSync.vhd
adding Pgp4RxLiteLowSpeed.vhd
…REERUN_G=false mode
Updates to AxiLiteSaciMaster.vhd & SaciMaster2.vhd
Mask off the Valid until the gearbox is locked
Pgp4RxLiteLowSpeedLane.vhd Update
Increased range of SACI_NUM_CHIPS_G to support more than 4 chips
…epare for asic deployment
introduce rst_polarity feature to all pgp4txlite/pgp4rx modules to prepare for asic deployment
_Qsfp.py Update
cbakalis-slac
requested changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments. Some code justification needed.
Regarding the sl vs std_logic_vector: maybe we need to do this on a different branch since it is a lot of work needed?
cbakalis-slac
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description