-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Release GIL in VFS bindings #3553
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
construction of python objects requires the GIL - read() doesn't correctly protect this code
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3553 +/- ##
==========================================
+ Coverage 86.21% 86.26% +0.04%
==========================================
Files 55 55
Lines 6348 6348
==========================================
+ Hits 5473 5476 +3
+ Misses 875 872 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: nguyenv <[email protected]>
Issue and/or context:
Follow up to #3543
Changes:
Release GIL for long-lived I/O methods
open
,read
, andseek
.