Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Release GIL in VFS bindings #3553

Merged
merged 4 commits into from
Jan 15, 2025
Merged

[python] Release GIL in VFS bindings #3553

merged 4 commits into from
Jan 15, 2025

Conversation

nguyenv
Copy link
Member

@nguyenv nguyenv commented Jan 10, 2025

Issue and/or context:

Follow up to #3543

Changes:

Release GIL for long-lived I/O methods open, read, and seek.

Copy link
Member

@bkmartinjr bkmartinjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

construction of python objects requires the GIL - read() doesn't correctly protect this code

@nguyenv nguyenv requested a review from bkmartinjr January 10, 2025 20:44
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.26%. Comparing base (1c8b1bd) to head (d725c32).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3553      +/-   ##
==========================================
+ Coverage   86.21%   86.26%   +0.04%     
==========================================
  Files          55       55              
  Lines        6348     6348              
==========================================
+ Hits         5473     5476       +3     
+ Misses        875      872       -3     
Flag Coverage Δ
python 86.26% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 86.26% <ø> (+0.04%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@nguyenv nguyenv merged commit ac7407e into main Jan 15, 2025
12 checks passed
@nguyenv nguyenv deleted the relase-vfs-gil branch January 15, 2025 16:04
github-actions bot pushed a commit that referenced this pull request Jan 15, 2025
johnkerl pushed a commit that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants