[python] Release GIL in VFS bindings (#3553)

single-cell-data · Jan 15, 2025 · ac7407e · ac7407e
1 parent 7616147
commit ac7407e
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/apis/python/src/tiledbsoma/soma_vfs.cc b/apis/python/src/tiledbsoma/soma_vfs.cc
@@ -80,8 +80,11 @@ class SOMAVFSFilebuf : public tiledb::impl::VFSFilebuf {
             return py::bytes("");
         }
 
+        py::gil_scoped_release release;
         std::string buffer(nbytes, '\0');
         offset_ += xsgetn(&buffer[0], nbytes);
+        py::gil_scoped_acquire acquire;
+
         return py::bytes(buffer);
     }
 
@@ -104,10 +107,16 @@ void load_soma_vfs(py::module& m) {
             "open",
             [](SOMAVFSFilebuf& buf, const std::string& uri) {
                 return buf.open(uri, std::ios::in);
-            })
+            },
+            py::call_guard<py::gil_scoped_release>())
         .def("read", &SOMAVFSFilebuf::read, "size"_a = -1)
         .def("tell", &SOMAVFSFilebuf::tell)
-        .def("seek", &SOMAVFSFilebuf::seek, "offset"_a, "whence"_a = 0)
+        .def(
+            "seek",
+            &SOMAVFSFilebuf::seek,
+            "offset"_a,
+            "whence"_a = 0,
+            py::call_guard<py::gil_scoped_release>())
         .def("close", &SOMAVFSFilebuf::close, "should_throw"_a = true);
 }
 }  // namespace libtiledbsomacpp