Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for braille format files #68

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

edwilde
Copy link
Contributor

@edwilde edwilde commented Oct 11, 2023

Relates to issue silverstripe/silverstripe-assets#573
and PR: silverstripe/silverstripe-framework#10970

This adds support for the Braille ASCII file format.

There is disagreement on what mime type brf files should be: datatypes.net says it should be application/octet-stream (ref), but apache says it should be text/plain (ref).

To be safe I have added both, however text/plain is likely to be the most used.

Issue

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Works great locally

@GuySartorelli GuySartorelli merged commit c9e9ee4 into silverstripe:3 Oct 25, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants