Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for braille format files #573

Closed
edwilde opened this issue Oct 11, 2023 · 2 comments
Closed

Add support for braille format files #573

edwilde opened this issue Oct 11, 2023 · 2 comments

Comments

@edwilde
Copy link
Contributor

edwilde commented Oct 11, 2023

Add support for the Braille ASCII file format to be allowed to be uploaded by CMS editors by default.

This is commonly asked for in the public sector and implemented using custom configuration.

Braille ASCII files are just plain text, so should not pose any security risk. However, I am not pen tester ;)

Notes

It seems, there is disagreement on what mime type brf files should be: datatypes.net says it should be application/octet-stream (ref), but apache says it should be text/plain (ref). In custom configurations we typically add both but text/plain seems to be more common.

Related issue

PRs

@GuySartorelli
Copy link
Member

PRs merged. This will be included in the Silverstripe CMS 5.2.0 release.

@edwilde
Copy link
Contributor Author

edwilde commented Oct 25, 2023

Thanks for your help with this @GuySartorelli, much appreciated 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants