Refactor identity monitoring into separate function #483
+119
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… verification pkg Signed-off-by: linus-sun <[email protected]>
Signed-off-by: linus-sun <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
==========================================
+ Coverage 64.02% 70.82% +6.79%
==========================================
Files 4 13 +9
Lines 303 802 +499
==========================================
+ Hits 194 568 +374
- Misses 78 179 +101
- Partials 31 55 +24 ☔ View full report in Codecov by Sentry. |
linus-sun
force-pushed
the
linussun/split-identity-search
branch
from
2f370e0
to
6fd3fdb
Compare
mihaimaruseac
previously approved these changes
Oct 14, 2024
There was a problem hiding this comment.
LGTM (reviewed only the last commit, as the other 2 seem to be #482)
Signed-off-by: linus-sun <[email protected]>
Signed-off-by: linus-sun <[email protected]>
linus-sun
force-pushed
the
linussun/split-identity-search
branch
from
6fd3fdb
to
1a3652a
Compare
linus-sun
force-pushed
the
linussun/split-identity-search
branch
from
404b723
to
11253dc
Compare
Signed-off-by: Linus Sun <[email protected]> Signed-off-by: linus-sun <[email protected]>
linus-sun
force-pushed
the
linussun/split-identity-search
branch
from
11253dc
to
299a8ac
Compare
haydentherapper
approved these changes
Oct 15, 2024
| @@ -118,39 +118,16 @@ func RunConsistencyCheck(interval *time.Duration, rekorClient *client.Rekor, ver | |||
| // Write if there was no stored checkpoint or the sizes differ | |||
| if prevCheckpoint == nil || prevCheckpoint.Size != checkpoint.Size { | |||
| if err := file.WriteCheckpoint(checkpoint, *logInfoFile); err != nil { | |||
| return fmt.Errorf("failed to write checkpoint: %v", err) | |||
| // TODO: Once the consistency check and identity search are split into separate tasks, this should hard fail. | |||
| // Temporarily skipping this to allow this job to succeed, remediating the issue noted here: https://github.com/sigstore/rekor-monitor/issues/271 | |||
There was a problem hiding this comment.
This issue is more about handling failures for in writeIdentitiesBetweenCheckpoints where processing a single entry throws an error. Gracefully handling this would mean skipping the index and logging it somewhere.
This has to be fixed deeper in the stack, around MatchedIndices where we return both successfully matched indices and failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Per this design doc, this PR refactors the monitored identity portion of rekor-monitor's reusable monitoring workflow into a separate function, for preparation in splitting up the workflow into two separate tasks, a consistency check and an identity monitor. A conditional check is added to see if a workflow input contains identities to monitor for.
This PR also temporarily changes a failing identity search to not hard fail the task, allowing the job to succeed and remediating the issue listed here. Future PRs will split this identity search into another task, allowing it to file a GitHub issue and not causing the consistency check to fail.
This PR depends on PR #482.
Release Note
NONE
Documentation
N/A - future PRs will update documentation once CLI/workflow functionality is altered.