Refactor monitoring workflow inputs #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linus-sun
changed the title
linus-sun
force-pushed
the
linussun/refactor-workflow-inputs
branch
from
dc9d74a
to
4ab1f56
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #489 +/- ##
==========================================
+ Coverage 64.02% 70.92% +6.89%
==========================================
Files 4 13 +9
Lines 303 815 +512
==========================================
+ Hits 194 578 +384
- Misses 78 182 +104
- Partials 31 55 +24 ☔ View full report in Codecov by Sentry. |
linus-sun
force-pushed
the
linussun/refactor-workflow-inputs
branch
from
4ab1f56
to
38115b4
Compare
linus-sun
requested review from
mihaimaruseac and
haydentherapper
and removed request for
mihaimaruseac
linus-sun
force-pushed
the
linussun/refactor-workflow-inputs
branch
2 times, most recently
from
80a1d48
to
72a5e00
Compare
mihaimaruseac
previously approved these changes
Oct 15, 2024
Signed-off-by: linus-sun <[email protected]>
linus-sun
dismissed
mihaimaruseac’s stale review
The merge-base changed after approval.
linus-sun
force-pushed
the
linussun/refactor-workflow-inputs
branch
from
72a5e00
to
3599a68
Compare
haydentherapper
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of the refactoring work outlined in this doc, this PR refactors the RunConsistencyCheck workflow to take in string/boolean values directly from parsed flag inputs instead of pointers. In doing so, this PR adds a function to check that CLI flags are set correctly and verifies as such in the reusable monitoring workflow.
This PR depends on #483; this is the relevant commit introducing the workflow input changes from pointer to static variable inputs.
Release Note
NONE
Documentation
N/A