Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SessionRecorder type-definitions to match their use #684

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

jzaleski
Copy link
Contributor

Description

This change-set updates the type-definition and quick-start for SplunkSessionRecorder to match the preferred default-configuration.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

How has this been tested?

  • Manual testing

@jzaleski
Copy link
Contributor Author

@t2t2 can you please give this a review when you have a moment?

@t2t2 t2t2 merged commit a9d9cf4 into signalfx:main Oct 16, 2023
3 of 5 checks passed
@jzaleski
Copy link
Contributor Author

Thank you @t2t2 / @mhennoch -- when can we expect to see this in a release?

@jzaleski jzaleski deleted the update-SessionRecorder-type-definitions branch October 16, 2023 13:22
@t2t2
Copy link
Contributor

t2t2 commented Oct 17, 2023

Now released - https://github.com/signalfx/splunk-otel-js-web/releases/tag/v0.16.5

@jzaleski
Copy link
Contributor Author

Now released - https://github.com/signalfx/splunk-otel-js-web/releases/tag/v0.16.5

Excellent! It was a great experience working w/ you. Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants