Update SessionRecorder type-definitions to match their use
#680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzaleski
had a problem deploying
to
integration
GitHub Actions
Failure
|
Even though github will auto-sign the squashed commit, there's a bug which prevents us from merging in case any of the to be merged commits aren't signed. Please sign your commit so we can merge this
(Saucelabs tests failing is fine as it requires access to secrets which PRs from forks don't have access to, other ci fails can be fixed by updating from base branch) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change-set updates the type-definition and quick-start for
SplunkSessionRecorderto match the preferred default-configuration.Type of change
How has this been tested?