Chore: Setting go versions to be current #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
approved these changes
Oct 24, 2024
Due to the update in path matching in the http mux beyond 1.21, it means that `%2f` is treated differently in path matching. To address this within tests, the wildcard is used in its place
|
There is a fun change that happened as part of 1.21, the default mux changed how it handles path and pattern matching meaning the The workaround was to add wildcards and that has worked for the tests. |
MovieStoreGuy
commented
Oct 24, 2024
There was a problem hiding this comment.
Added some additional changes here to use require instead of assert, since it would cause a panic on nil error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Setting the versions to reflect the current LTS of go and previous version.
Changes