Feature: Adding standardize response error #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MovieStoreGuy
force-pushed
the
msg/none-add-fixed-errors
branch
from
ee9faec to
7424c54
Compare
|
Requires #226 |
To help simplify and address how errors from request are handled, this returns an error type that allows for deeper introspection from external packages.
MovieStoreGuy
force-pushed
the
msg/none-add-fixed-errors
branch
from
8d7ceb7 to
00bf849
Compare
atoulme
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
To help simplify and address how errors from responses are handled, this returns an error type that allows for deeper introspection from external packages.
This is helpful in projects like the signalfx-terraform-provider since it currently determines type of error by searching the error message for the expected status code, this could improve by returning a more complex error type to provide the improved level of introspection.
Changes
ResponseErrorResponseErrorwith methods to create and inspect.