Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deprecated properties #1581

Open
wants to merge 19 commits into
base: release-3.0.0
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 16 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions .changeset/afraid-papayas-own.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
---
'eslint-config-ix': major
nuke-ellington marked this conversation as resolved.
Show resolved Hide resolved
'@siemens/ix-angular': major
'@siemens/ix-echarts': major
'@siemens/ix-aggrid': major
'@siemens/ix-react': major
'@siemens/ix': major
'@siemens/ix-vue': major
---

Component Updates and Enhancements

New Variants for Card Components:
- **ix-action-card**, **ix-card**, and **ix-push-card**:
- The `insight` and `notification` variants have been **replaced by** `outline` and `filled`.

Property Updates:
- **ix-chip**:
- The `color` property has been **replaced by** `chipColor`.
- **ix-event-list**:
- The `color` attribute has been **replaced by** `itemColor`.
- **ix-icon-button**:
- The `color` attribute has been **replaced by** `iconColor`.
- Size `32` has been removed.
- **ix-pill**:
- The `color` attribute has been **replaced by** `pillColor`.
- **ix-typography**:
- The `color` attribute has been **replaced by** `textColor`.
- **ix-select**:
- The `selectedIndices` attribute has been **replaced by** `value`.
- The `itemSelectionChange` event has been **replaced by** `valueChange`.
- **ix-select-item**:
- The `value` attribute type has been updated to `string`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- The `value` attribute type has been updated to `string`.
- The type of the `value` property has been updated to `string`.


Date and Time Picker Enhancements:
- **ix-date-picker**:
- Removed attributes: `individual` and `eventDelimiter`.
- The `textSelectedDate` property has been **replaced by** `i18nDone`.
- The `done` event has been **replaced by** `dateSelect`.
- **ix-datetime-picker**:
- The `textSelectedDate` property has been **replaced by** `i18nDone`.
- The `done` event has been **replaced by** `dateSelect`.
- Removed the `eventDelimiter` property.
- **ix-time-picker**:
- Removed attributes: `individual` and `showTimeReference`.

Removed Features:
- **ix-menu**:
- Removed the `maxVisibleMenuItems` attribute.
- **ix-menu-item**:
- The `tabIcon` attribute has been removed and replaced with `icon`.

Other Changes:
- **ix-modal**:
- The `keyboard` attribute has been **replaced by** `closeOnEscape`.
58 changes: 58 additions & 0 deletions BREAKING_CHANGES/v3.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Breaking changes v3

Here is a detailed overview of the significant changes introduced in the major updates of Siemens industrial experience.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Here is a detailed overview of the significant changes introduced in the major updates of Siemens industrial experience.
Here is a detailed overview of all breaking changes introduced in this major update of Siemens Industrial Experience.


## Remove package `@siemens/ix-icons` from `@siemens/ix` base library

The `@siemens/ix-icons` package requires manual bootstrapping. For detailed installation instructions, please refer to the [`@siemens/ix-icons`](https://github.com/siemens/ix-icons) repository.
Expand Down Expand Up @@ -118,3 +120,59 @@ The following component members marked as internal by comment have been changed
- `ix-menu-about-news`: `expanded`
- `ix-menu-settings`: `show`
- `ix-dropdown-item`: `emitItemClick()`

## Component Updates

#### ix-action-card
- The `insight` and `notification` variants have been **replaced by** `outline` and `filled`.

#### ix-card
- The `insight` and `notification` variants have been **replaced by** `outline` and `filled`.

#### ix-chip
- The `color` property has been **replaced by** `chipColor`.

#### ix-date-picker
- Removed attributes: `individual`, and `eventDelimiter`.
- The `textSelectedDate` property has been **replaced by** `i18nDone`.
- The `done` event has been **replaced by** `dateSelect`.

#### ix-datetime-picker
- The `textSelectedDate` property has been **replaced by** `i18nDone`.
- The `done` event has been **replaced by** `dateSelect`.
- The `eventDelimiter` property was also removed as part of the adjustment.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- The `eventDelimiter` property was also removed as part of the adjustment.
- The `eventDelimiter` property has been removed.


#### ix-event-list
- The `color` attribute has been **replaced by** `itemColor`.

#### ix-icon-button
- The `color` attribute has been **replaced by** `iconColor`.
- size `32` has been removed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- size `32` has been removed.
- Size `32` has been removed.


#### ix-menu
- Removed the `maxVisibleMenuItems` attribute.

#### ix-menu-item
- Removed the `tabIcon` attribute and replaced with icon.

#### ix-modal
- The `keyboard` attribute has been **replaced by** `closeOnEscape`.

#### ix-pill
- The `color` attribute has been **replaced by** `pillColor`.

#### ix-push-card
- The `insight` and `notification` variants have been **replaced by** `outline` and `filled`.

#### ix-select
- The `selectedIndices` attribute has been **replaced by** `value`.
- The `itemSelectionChange` event has been **replaced by** `valueChange`.

#### ix-select-item
- The `value` attribute type has been changed to `string`.

#### ix-time-picker
- Removed attributes: `individual` and `showTimeReference`.

#### ix-typography
- The `color` attribute has been **replaced by** `textColor`.
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
icon="refresh"
heading="Scan for new devices"
subheading="Secondary text"
variant="insight"
variant="outline"
(click)="onClick($event)"
></ix-action-card>
10 changes: 5 additions & 5 deletions packages/angular-test-app/src/preview-examples/card-list.html
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
notification="3"
heading="Heading content"
subheading="Subheading"
variant="notification"
variant="filled"
></ix-push-card>
<ix-push-card
icon="bulb"
Expand All @@ -37,7 +37,7 @@
notification="3"
heading="Heading content"
subheading="Subheading"
variant="notification"
variant="filled"
></ix-push-card>
<ix-push-card
icon="bulb"
Expand All @@ -51,20 +51,20 @@
notification="3"
heading="Heading content"
subheading="Subheading"
variant="notification"
variant="filled"
></ix-push-card>
<ix-push-card
icon="rocket"
notification="3"
heading="Heading content"
subheading="Subheading"
variant="notification"
variant="filled"
></ix-push-card>
<ix-push-card
icon="rocket"
notification="3"
heading="Heading content"
subheading="Subheading"
variant="notification"
variant="filled"
></ix-push-card>
</ix-card-list>
2 changes: 1 addition & 1 deletion packages/angular-test-app/src/preview-examples/card.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
LICENSE file in the root directory of this source tree.
-->

<ix-card (click)="onClick($event)" variant="insight">
<ix-card (click)="onClick($event)" variant="outline">
<ix-card-content>
<ix-icon name="capacity"></ix-icon>
<ix-typography bold>Number of components</ix-typography>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
notification="99"
heading="Heading content"
subheading="Subheading"
variant="insight"
variant="outline"
>
<table class="table">
<thead>
Expand Down
Loading
Loading