fix: remove deprecated properties #1581
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0dc057a The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Report of
|
nuke-ellington
requested changes
Dec 3, 2024
BREAKING_CHANGES/v3.md
Outdated
| @@ -1,5 +1,7 @@ | |||
| # Breaking changes v3 | |||
|
|
|||
| Here is a detailed overview of the significant changes introduced in the major updates of Siemens industrial experience. | |||
There was a problem hiding this comment.
Suggested change
| Here is a detailed overview of the significant changes introduced in the major updates of Siemens industrial experience. | |
| Here is a detailed overview of all breaking changes introduced in this major update of Siemens Industrial Experience. |
.changeset/afraid-papayas-own.md
Outdated
| - The `selectedIndices` attribute has been **replaced by** `value`. | ||
| - The `itemSelectionChange` event has been **replaced by** `valueChange`. | ||
| - **ix-select-item**: | ||
| - The `value` attribute type has been updated to `string`. |
There was a problem hiding this comment.
Suggested change
| - The `value` attribute type has been updated to `string`. | |
| - The type of the `value` property has been updated to `string`. |
BREAKING_CHANGES/v3.md
Outdated
| #### ix-datetime-picker | ||
| - The `textSelectedDate` property has been **replaced by** `i18nDone`. | ||
| - The `done` event has been **replaced by** `dateSelect`. | ||
| - The `eventDelimiter` property was also removed as part of the adjustment. |
There was a problem hiding this comment.
Suggested change
| - The `eventDelimiter` property was also removed as part of the adjustment. | |
| - The `eventDelimiter` property has been removed. |
BREAKING_CHANGES/v3.md
Outdated
|
|
||
| #### ix-icon-button | ||
| - The `color` attribute has been **replaced by** `iconColor`. | ||
| - size `32` has been removed. |
There was a problem hiding this comment.
Suggested change
| - size `32` has been removed. | |
| - Size `32` has been removed. |
| @@ -183,7 +183,7 @@ export class FormFieldLabel implements IxComponent { | |||
| ref={this.labelRef} | |||
| > | |||
| <ix-typography | |||
| color={this.isInvalid ? 'alarm' : 'soft'} | |||
| textColor={this.isInvalid ? 'alarm' : 'soft'} | |||
There was a problem hiding this comment.
Suggested change
| textColor={this.isInvalid ? 'alarm' : 'soft'} | |
| text-color={this.isInvalid ? 'alarm' : 'soft'} |
There was a problem hiding this comment.
textColor should be okay in here, shouldn't it?
nuke-ellington
requested changes
Dec 3, 2024
| @@ -297,7 +297,7 @@ export class Slider { | |||
| </div> | |||
| </div> | |||
| {this.error ? ( | |||
| <ix-typography class={'label-error'} color="alarm"> | |||
| <ix-typography class={'label-error'} text-color="alarm"> | |||
There was a problem hiding this comment.
Suggested change
| <ix-typography class={'label-error'} text-color="alarm"> | |
| <ix-typography class={'label-error'} textColor="alarm"> |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 What is the current behavior?
GitHub Issue Number: #N/A, [IX-1601]
🆕 What is the new behavior?
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm run docs)pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support