Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use redirect manual in fetch #24

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: use redirect manual in fetch #24

merged 1 commit into from
Nov 25, 2024

Conversation

shyim
Copy link
Member

@shyim shyim commented Nov 25, 2024

No description provided.

@shyim shyim requested a review from Copilot November 25, 2024 08:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 suggestions.

Comments skipped due to low confidence (2)

src/http-client.test.ts:184

  • The test name 'test authentification gets redirect' is duplicated. Test names should be unique to avoid confusion.
test("test authentification gets redirect", async () => {

src/http-client.test.ts:198

  • The test name 'test authentification gets redirect' is duplicated. Test names should be unique to avoid confusion.
test("test authentification gets redirect", async () => {

src/http-client.test.ts Show resolved Hide resolved
src/http-client.test.ts Outdated Show resolved Hide resolved
@shyim shyim requested a review from Copilot November 25, 2024 08:27

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (2)

src/http-client.test.ts:184

  • [nitpick] The test case name 'test authentication gets redirect' is duplicated. Each test case should have a unique name to avoid confusion.
test("test authentication gets redirect", async () => {

src/http-client.test.ts:198

  • [nitpick] The test case name 'test authentication gets redirect' is duplicated. Each test case should have a unique name to avoid confusion.
test("test authentication gets redirect", async () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.

@shyim shyim merged commit da0316b into main Nov 25, 2024
2 checks passed
@shyim shyim deleted the fix-redirect-error branch November 25, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant