fix: use redirect manual in fetch

src/http-client.test.ts

@@ -118,7 +118,7 @@ describe("HTTP Client", async () => {
 		expect(mockFetch.mock.lastCall?.[0]).toBe("test/api/test");
 		expect(mockFetch.mock.lastCall?.[1]).toEqual({
 			body: form,
-			redirect: "error",
+			redirect: "manual",
 			headers: {
 				Authorization: "Bearer test",
 				accept: "application/json",
@@ -147,7 +147,7 @@ describe("HTTP Client", async () => {
 		expect(mockFetch.mock.lastCall?.[0]).toBe("test/api/test");
 		expect(mockFetch.mock.lastCall?.[1]).toEqual({
 			body: JSON.stringify(form),
-			redirect: "error",
+			redirect: "manual",
 			headers: {
 				Authorization: "Bearer test",
 				accept: "application/json",
@@ -180,4 +180,40 @@ describe("HTTP Client", async () => {
 
 		mockFetch.mockRestore();
 	});
+
+	test("test authentification gets redirect", async () => {
+		const mockFetch = spyOn(global, "fetch").mockImplementationOnce(() =>
+			Promise.resolve(new Response("", { status: 301 })),
+		);
+
+		const client = new HttpClient(new SimpleShop("blaa", "test", "test"));
+
+		expect(client.get("/test")).rejects.toThrowError(
+			"Request failed with error: Got a redirect response from the URL, the URL should point to the Shop without redirect for shop with id: blaa",
+		);
+
+		mockFetch.mockRestore();
+	});
+
+	test("gets redirect on a api route", async () => {
+		const mockFetch = spyOn(global, "fetch").mockImplementation(
+			(input, init) => {
+				if (input === "test/api/oauth/token") {
+					return Promise.resolve(
+						new Response('{"access_token": "test", "expires_in": 5000}'),
+					);
+				}
+
+				return Promise.resolve(new Response("", { status: 301 }));
+			},
+		);
+
+		const client = new HttpClient(new SimpleShop("blaa", "test", "test"));
+
+		expect(client.post("/test", {})).rejects.toThrowError(
+			"Request failed with error: Got a redirect response from the URL, the URL should point to the Shop without redirect for shop with id: blaa",
+		);
+
+		mockFetch.mockRestore();
+	});
 });

src/http-client.ts

@@ -97,7 +97,7 @@ export class HttpClient {
 		headers: Record<string, string> = {},
 	): Promise<HttpClientResponse<ResponseType>> {
 		const f = await globalThis.fetch(`${this.shop.getShopUrl()}/api${url}`, {
-			redirect: "error",
+			redirect: "manual",
 			body,
 			headers: Object.assign(
 				{
@@ -108,6 +108,27 @@ export class HttpClient {
 			method,
 		});
 
+		if (f.status === 301 || f.status === 302) {
+			throw new ApiClientRequestFailed(
+				this.shop.getShopId(),
+				new HttpClientResponse<ShopwareErrorResponse>(
+					f.status,
+					{
+						errors: [
+							{
+								code: "301",
+								status: "301",
+								title: "301",
+								detail:
+									"Got a redirect response from the URL, the URL should point to the Shop without redirect",
+							},
+						],
+					},
+					f.headers,
+				),
+			);
+		}
+
 		// Obtain new token
 		if (!f.ok && f.status === 401) {
 			this.storage.expiresIn = null;
@@ -141,7 +162,7 @@ export class HttpClient {
 				`${this.shop.getShopUrl()}/api/oauth/token`,
 				{
 					method: "POST",
-					redirect: "error",
+					redirect: "manual",
 					headers: {
 						"content-type": "application/json",
 					},
@@ -153,6 +174,27 @@ export class HttpClient {
 				},
 			);
 
+			if (auth.status === 301 || auth.status === 302) {
+				throw new ApiClientRequestFailed(
+					this.shop.getShopId(),
+					new HttpClientResponse<ShopwareErrorResponse>(
+						auth.status,
+						{
+							errors: [
+								{
+									code: "301",
+									status: "301",
+									title: "301",
+									detail:
+										"Got a redirect response from the URL, the URL should point to the Shop without redirect",
+								},
+							],
+						},
+						auth.headers,
+					),
+				);
+			}
+
 			if (!auth.ok) {
 				const contentType = auth.headers.get("content-type") || "text/plain";
 				let body = "";