-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Fixes #1581
CI Fixes #1581
Changes from 6 commits
ef7409f
cedbe13
a71962f
16cfc19
6f7269a
7dc7103
ac8e211
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,11 @@ | ||
name: Lint JS and Ruby | ||
|
||
on: [push, pull_request] | ||
|
||
on: | ||
push: | ||
branches: | ||
- 'master' | ||
pull_request: | ||
|
||
jobs: | ||
build: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,17 @@ | ||
name: Main test | ||
|
||
on: [push, pull_request] | ||
on: | ||
push: | ||
branches: | ||
- 'master' | ||
pull_request: | ||
|
||
jobs: | ||
build-dummy-app-webpack-test-bundles: | ||
strategy: | ||
matrix: | ||
ruby: [2.7, 3.2] | ||
node: [16, 18] | ||
node: [14, 16, 18] | ||
runs-on: ubuntu-22.04 | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
@@ -79,8 +83,8 @@ jobs: | |
needs: build-dummy-app-webpack-test-bundles | ||
strategy: | ||
matrix: | ||
ruby: [2.7] | ||
node: [14] | ||
ruby: [2.7, 3.2] | ||
node: [14, 16, 18] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. newer node should be added |
||
rake_task: ['run_rspec:all_but_examples', 'run_rspec:examples'] | ||
runs-on: ubuntu-22.04 | ||
steps: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,17 @@ | ||
name: JS unit tests for Renderer package | ||
|
||
on: [push, pull_request] | ||
|
||
on: | ||
push: | ||
branches: | ||
- 'master' | ||
pull_request: | ||
|
||
jobs: | ||
build: | ||
strategy: | ||
matrix: | ||
node: [16, 18] | ||
node: [14, 16, 18] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. newer node |
||
runs-on: ubuntu-22.04 | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,17 @@ | ||
name: Rspec test for gem | ||
|
||
on: [push, pull_request] | ||
on: | ||
push: | ||
branches: | ||
- 'master' | ||
pull_request: | ||
|
||
jobs: | ||
build: | ||
strategy: | ||
matrix: | ||
ruby: [2.7, 3.2] | ||
node: [16, 18] | ||
node: [14, 16, 18] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same |
||
runs-on: ubuntu-22.04 | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any particular reason for bringing back Node 14?
Before we decided to drop support for Node 14. (Though it seems I missed it in some other places)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we dropped support for it, then we need to tell Justin to remove any workflows for Node v14 from the list of required workflows.