CI Fixes #1581
Merged
CI Fixes #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahangarha
reviewed
Nov 14, 2023
.github/workflows/main.yml
Outdated
|
|
||
| jobs: | ||
| build-dummy-app-webpack-test-bundles: | ||
| strategy: | ||
| matrix: | ||
| ruby: [2.7, 3.2] | ||
| node: [16, 18] | ||
| node: [14, 16, 18] |
There was a problem hiding this comment.
Is there any particular reason for bringing back Node 14?
Before we decided to drop support for Node 14. (Though it seems I missed it in some other places)
There was a problem hiding this comment.
If we dropped support for it, then we need to tell Justin to remove any workflows for Node v14 from the list of required workflows.
justin808
requested changes
Nov 15, 2023
.github/workflows/main.yml
Outdated
| ruby: [2.7] | ||
| node: [14] | ||
| ruby: [2.7, 3.2] | ||
| node: [14, 16, 18] |
|
|
||
| jobs: | ||
| build: | ||
| strategy: | ||
| matrix: | ||
| node: [16, 18] | ||
| node: [14, 16, 18] |
|
|
||
| jobs: | ||
| build: | ||
| strategy: | ||
| matrix: | ||
| ruby: [2.7, 3.2] | ||
| node: [16, 18] | ||
| node: [14, 16, 18] |
ahangarha
approved these changes
Nov 15, 2023
justin808
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades Puma to v6 to make it compatible with Rack v3.
This PR also adds new workflows so that all workflows required by our repository settings actually run.
This change is