fix rank reduction warning

settylab · Nov 28, 2022 · a88d305 · a88d305
1 parent 54dcd07
commit a88d305
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/mellon/model.py b/mellon/model.py
@@ -142,9 +142,10 @@ def _compute_L(self):
             x, cov_func, landmarks=landmarks, rank=rank, method=method, jitter=jitter
         )
         new_rank = L.shape[1]
-        if new_rank > (.8*rank):
+        old_rank = landmarks.shape[0]
+        if new_rank > (.8*old_rank):
             warn(
-                f'Shallow rank reduction from {rank:,} to {new_rank:,} '
+                f'Shallow rank reduction from {old_rank:,} to {new_rank:,} '
                 'indicates underrepresentation by landmarks. Consider '
                 'increasing n_landmarks!'
             )