Integrate session pallet into validator-sets pallet #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akildemir
force-pushed
the
session-pallet
branch
from
7feaf9e to
ad8f817
Compare
Sets validators for BABE/GRANDPA in chain_spec, per Akil's realization that was the missing piece.
kayabaNerve
force-pushed
the
session-pallet
branch
from
1ce936b to
7be428a
Compare
kayabaNerve
reviewed
Nov 21, 2023
There was a problem hiding this comment.
CI failure is related. Many of my comments may just require an explanation on my end. Seems overall straightforward though :)
CI logs:
2023-11-20T10:29:33.1158090Z thread 'tokio-runtime-worker' panicked at coordinator/src/substrate/mod.rs:81:12:
2023-11-20T10:29:33.1159310Z validator selected for set yet didn't have an allocation
2023-11-20T10:29:33.1160256Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2023-11-20T10:29:33.1161558Z [2023-11-20T10:19:25Z ERROR serai_coordinator] exiting the process due to a task panicking
kayabaNerve
reviewed
Nov 22, 2023
kayabaNerve
reviewed
Nov 22, 2023
kayabaNerve
reviewed
Nov 22, 2023
kayabaNerve
reviewed
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pallet-sessionfunctionality from validator sets pallet.pallet-sessionandpallet-authority-discoverypallets completely from runtime.