Skip to content

Implements feature based perf instrumentation comparision #3156

Implements feature based perf instrumentation comparision

Implements feature based perf instrumentation comparision #3156

Triggered via pull request November 14, 2023 10:12
Status Success
Total duration 29s
Artifacts

pre-commit.yml

on: pull_request
pre-commit
21s
pre-commit
Fit to window
Zoom out
Zoom in

Annotations

102 errors and 54 warnings
[mypy] varats-core/varats/report/tef_report.py#L72: varats-core/varats/report/tef_report.py#L72
error: Attribute "__uuid" already defined on line 70 [no-redef]
[mypy] varats-core/varats/report/tef_report.py#L75: varats-core/varats/report/tef_report.py#L75
error: Attribute "__uuid" already defined on line 70 [no-redef]
[mypy] varats-core/varats/report/tef_report.py#L155: varats-core/varats/report/tef_report.py#L155
error: Function is missing a return type annotation [no-untyped-def]
[mypy] varats-core/varats/report/tef_report.py#L155: varats-core/varats/report/tef_report.py#L155
note: Use "-> None" if function does not return a value
[mypy] varats-core/varats/report/tef_report.py#L173: varats-core/varats/report/tef_report.py#L173
error: Call to untyped function "_patch_errors_from_file" in typed context [no-untyped-call]
[mypy] varats-core/varats/report/tef_report.py#L210: varats-core/varats/report/tef_report.py#L210
error: Function is missing a return type annotation [no-untyped-def]
[mypy] varats-core/varats/report/tef_report.py#L210: varats-core/varats/report/tef_report.py#L210
note: Use "-> None" if function does not return a value
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L115: varats/varats/experiments/vara/feature_perf_precision.py#L115
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L157: varats/varats/experiments/vara/feature_perf_precision.py#L157
error: Argument 2 to "__init__" of "MultiPatchReport" has incompatible type "type[PerfInfluenceTraceReportAggregate]"; expected "type[TEFReportAggregate]" [arg-type]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L168: varats/varats/experiments/vara/feature_perf_precision.py#L168
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L221: varats/varats/experiments/vara/feature_perf_precision.py#L221
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L323: varats/varats/experiments/vara/feature_perf_precision.py#L323
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L465: varats/varats/experiments/vara/feature_perf_precision.py#L465
error: Call to untyped function "RevertPatch" in typed context [no-untyped-call]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L586: varats/varats/experiments/vara/feature_perf_precision.py#L586
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L703: varats/varats/experiments/vara/feature_perf_precision.py#L703
error: Call to untyped function "RevertPatch" in typed context [no-untyped-call]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L738: varats/varats/experiments/vara/feature_perf_precision.py#L738
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L795: varats/varats/experiments/vara/feature_perf_precision.py#L795
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L869: varats/varats/experiments/vara/feature_perf_precision.py#L869
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L1089: varats/varats/experiments/vara/feature_perf_precision.py#L1089
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/data/databases/feature_perf_precision_database.py#L10: varats/varats/data/databases/feature_perf_precision_database.py#L10
error: Skipping analyzing "cliffs_delta": module is installed, but missing library stubs or py.typed marker [import-untyped]
[mypy] varats/varats/data/databases/feature_perf_precision_database.py#L10: varats/varats/data/databases/feature_perf_precision_database.py#L10
note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
[mypy] varats/varats/data/databases/feature_perf_precision_database.py#L303: varats/varats/data/databases/feature_perf_precision_database.py#L303
error: Module "varats.experiments.vara.feature_perf_precision" does not explicitly export attribute "MultiPatchReport" [attr-defined]
[mypy] varats/varats/data/databases/feature_perf_precision_database.py#L337: varats/varats/data/databases/feature_perf_precision_database.py#L337
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/data/databases/feature_perf_precision_database.py#L359: varats/varats/data/databases/feature_perf_precision_database.py#L359
error: Module "varats.experiments.vara.feature_perf_precision" does not explicitly export attribute "MultiPatchReport" [attr-defined]
[mypy] varats/varats/data/databases/feature_perf_precision_database.py#L360: varats/varats/data/databases/feature_perf_precision_database.py#L360
error: Module "varats.experiments.vara.feature_perf_precision" does not explicitly export attribute "PerfInfluenceTraceReportAggregate" [attr-defined]
[mypy] varats/varats/data/databases/feature_perf_precision_database.py#L394: varats/varats/data/databases/feature_perf_precision_database.py#L394
error: Module "varats.experiments.vara.feature_perf_precision" does not explicitly export attribute "MultiPatchReport" [attr-defined]
[mypy] varats/varats/data/databases/feature_perf_precision_database.py#L520: varats/varats/data/databases/feature_perf_precision_database.py#L520
error: Module "varats.experiments.vara.feature_perf_precision" does not explicitly export attribute "TimeReportAggregate" [attr-defined]
[mypy] varats/varats/data/databases/feature_perf_precision_database.py#L523: varats/varats/data/databases/feature_perf_precision_database.py#L523
error: Signature of "is_regression" incompatible with supertype "Profiler" [override]
[mypy] varats/varats/data/databases/feature_perf_precision_database.py#L523: varats/varats/data/databases/feature_perf_precision_database.py#L523
note: def is_regression(self, report_path: ReportFilepath, patch_name: str) -> bool
[mypy] varats/varats/data/databases/feature_perf_precision_database.py#L571: varats/varats/data/databases/feature_perf_precision_database.py#L571
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/data/databases/feature_perf_precision_database.py#L714: varats/varats/data/databases/feature_perf_precision_database.py#L714
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/data/databases/feature_perf_precision_database.py#L774: varats/varats/data/databases/feature_perf_precision_database.py#L774
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/tables/feature_perf_precision.py#L36: varats/varats/tables/feature_perf_precision.py#L36
error: Module "varats.utils.git_util" does not explicitly export attribute "git" [attr-defined]
[mypy] varats/varats/tables/feature_perf_precision.py#L39: varats/varats/tables/feature_perf_precision.py#L39
error: Function is missing a type annotation [no-untyped-def]
[mypy] varats/varats/tables/feature_perf_precision.py#L52: varats/varats/tables/feature_perf_precision.py#L52
error: Incompatible types in assignment (expression has type "ndarray[Any, dtype[Any]]", variable has type "list[Any]") [assignment]
[mypy] varats/varats/tables/feature_perf_precision.py#L251: varats/varats/tables/feature_perf_precision.py#L251
error: "OverheadData" has no attribute "mean_ctx" [attr-defined]
[mypy] varats/varats/tables/feature_perf_precision.py#L262: varats/varats/tables/feature_perf_precision.py#L262
error: "OverheadData" has no attribute "config_wise_ctx_diff"; maybe "config_wise_time_diff", "config_wise_memory_diff", or "config_wise_fs_inputs_diff"? [attr-defined]
[mypy] varats/varats/tables/feature_perf_precision.py#L361: varats/varats/tables/feature_perf_precision.py#L361
error: Function is missing a type annotation [no-untyped-def]
[mypy] varats/varats/tables/feature_perf_precision.py#L475: varats/varats/tables/feature_perf_precision.py#L475
error: Call to untyped function "cmap_map" in typed context [no-untyped-call]
[mypy] varats/varats/tables/feature_perf_precision.py#L491: varats/varats/tables/feature_perf_precision.py#L491
error: Call to untyped function "truncate_colormap" in typed context [no-untyped-call]
[mypy] varats/varats/plots/feature_perf_precision.py#L301: varats/varats/plots/feature_perf_precision.py#L301
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/plots/feature_perf_precision.py#L317: varats/varats/plots/feature_perf_precision.py#L317
error: Name "text_obj" already defined on line 316 [no-redef]
[mypy] varats/varats/plots/feature_perf_precision.py#L358: varats/varats/plots/feature_perf_precision.py#L358
error: Call to untyped function "plot_pareto_frontier" in typed context [no-untyped-call]
[mypy] varats/varats/plots/feature_perf_precision.py#L404: varats/varats/plots/feature_perf_precision.py#L404
error: Function is missing a type annotation [no-untyped-def]
[pylint] varats/varats/tables/feature_perf_precision.py#L6 <402>: varats/varats/tables/feature_perf_precision.py#L6
Use 'from matplotlib import colors' instead (consider-using-from-import)
[pylint] varats/varats/tables/feature_perf_precision.py#L54 <3001>: varats/varats/tables/feature_perf_precision.py#L54
Lambda expression assigned to a variable. Define a function using the "def" keyword instead. (unnecessary-lambda-assignment)
[pylint] varats/varats/tables/feature_perf_precision.py#L55 <103>: varats/varats/tables/feature_perf_precision.py#L55
Variable name "old_LUT" doesn't conform to snake_case naming style (invalid-name)
[pylint] varats/varats/tables/feature_perf_precision.py#L56 <103>: varats/varats/tables/feature_perf_precision.py#L56
Variable name "new_LUT" doesn't conform to snake_case naming style (invalid-name)
[pylint] varats/varats/tables/feature_perf_precision.py#L70 <415>: varats/varats/tables/feature_perf_precision.py#L70
Import outside toplevel (matplotlib) (import-outside-toplevel)
[pylint] varats/varats/tables/feature_perf_precision.py#L251 <1101>: varats/varats/tables/feature_perf_precision.py#L251
Instance of 'OverheadData' has no 'mean_ctx' member (no-member)
[pylint] varats/varats/tables/feature_perf_precision.py#L262 <1101>: varats/varats/tables/feature_perf_precision.py#L262
Instance of 'OverheadData' has no 'config_wise_ctx_diff' member (no-member)
[pylint] varats/varats/tables/feature_perf_precision.py#L361 <116>: varats/varats/tables/feature_perf_precision.py#L361
Missing function or method docstring (missing-function-docstring)
[pylint] varats/varats/tables/feature_perf_precision.py#L363 <209>: varats/varats/tables/feature_perf_precision.py#L363
Formatting a regular string which could be an f-string (consider-using-f-string)
[pylint] varats/varats/plots/feature_perf_precision.py#L29 <116>: varats/varats/plots/feature_perf_precision.py#L29
Missing function or method docstring (missing-function-docstring)
[pylint] varats/varats/plots/feature_perf_precision.py#L301 <116>: varats/varats/plots/feature_perf_precision.py#L301
Missing function or method docstring (missing-function-docstring)
[pylint] varats/varats/plots/feature_perf_precision.py#L404 <103>: varats/varats/plots/feature_perf_precision.py#L404
Argument name "Xs" doesn't conform to snake_case naming style (invalid-name)
[pylint] varats/varats/plots/feature_perf_precision.py#L404 <103>: varats/varats/plots/feature_perf_precision.py#L404
Argument name "Ys" doesn't conform to snake_case naming style (invalid-name)
[pylint] varats/varats/plots/feature_perf_precision.py#L404 <103>: varats/varats/plots/feature_perf_precision.py#L404
Argument name "maxX" doesn't conform to snake_case naming style (invalid-name)
[pylint] varats/varats/plots/feature_perf_precision.py#L404 <103>: varats/varats/plots/feature_perf_precision.py#L404
Argument name "maxY" doesn't conform to snake_case naming style (invalid-name)
pre-commit
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-python@v2, pre-commit/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
[pylint] varats/varats/projects/cpp_projects/hyteg.py#L24 <611>: varats/varats/projects/cpp_projects/hyteg.py#L24
Unused init_all_submodules imported from varats.utils.git_commands (unused-import)
[pylint] varats/varats/experiments/vara/feature_perf_precision.py#L155 <511>: varats/varats/experiments/vara/feature_perf_precision.py#L155
TODO: clean up report handling, we currently parse it as a TEFReport (fixme)
[pylint] varats/varats/experiments/vara/feature_perf_precision.py#L168 <246>: varats/varats/experiments/vara/feature_perf_precision.py#L168
Useless parent or super() delegation in method '__init__' (useless-parent-delegation)
[pylint] varats/varats/experiments/vara/feature_perf_precision.py#L221 <246>: varats/varats/experiments/vara/feature_perf_precision.py#L221
Useless parent or super() delegation in method '__init__' (useless-parent-delegation)
[pylint] varats/varats/experiments/vara/feature_perf_precision.py#L323 <246>: varats/varats/experiments/vara/feature_perf_precision.py#L323
Useless parent or super() delegation in method '__init__' (useless-parent-delegation)
[pylint] varats/varats/experiments/vara/feature_perf_precision.py#L19 <611>: varats/varats/experiments/vara/feature_perf_precision.py#L19
Unused get_base_image imported from varats.containers.containers (unused-import)
[pylint] varats/varats/experiments/vara/feature_perf_precision.py#L19 <611>: varats/varats/experiments/vara/feature_perf_precision.py#L19
Unused ImageBase imported from varats.containers.containers (unused-import)
[pylint] varats/varats/tables/feature_perf_precision.py#L448 <1401>: varats/varats/tables/feature_perf_precision.py#L448
Anomalous backslash in string: '\D'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
[pylint] varats/varats/tables/feature_perf_precision.py#L448 <1401>: varats/varats/tables/feature_perf_precision.py#L448
Anomalous backslash in string: '\%'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
[pylint] varats/varats/tables/feature_perf_precision.py#L449 <1401>: varats/varats/tables/feature_perf_precision.py#L449
Anomalous backslash in string: '\D'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
[pylint] varats/varats/tables/feature_perf_precision.py#L449 <1401>: varats/varats/tables/feature_perf_precision.py#L449
Anomalous backslash in string: '\%'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
[pylint] varats/varats/tables/feature_perf_precision.py#L450 <1401>: varats/varats/tables/feature_perf_precision.py#L450
Anomalous backslash in string: '\D'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
[pylint] varats/varats/tables/feature_perf_precision.py#L46 <212>: varats/varats/tables/feature_perf_precision.py#L46
Access to a protected member _segmentdata of a client class (protected-access)
[pylint] varats/varats/tables/feature_perf_precision.py#L29 <611>: varats/varats/tables/feature_perf_precision.py#L29
Unused CaseStudy imported from varats.paper.case_study (unused-import)
[pylint] varats/varats/plots/feature_perf_precision.py#L23 <611>: varats/varats/plots/feature_perf_precision.py#L23
Unused PlotConfig imported from varats.plot.plots (unused-import)
[pylint] varats/varats/data/databases/feature_perf_precision_database.py#L523 <221>: varats/varats/data/databases/feature_perf_precision_database.py#L523
Number of parameters was 3 in 'Profiler.is_regression' and is now 2 in overriding 'Baseline.is_regression' method (arguments-differ)
[pylint] varats/varats/data/databases/feature_perf_precision_database.py#L616 <212>: varats/varats/data/databases/feature_perf_precision_database.py#L616
Access to a protected member __mean_major_page_faults of a client class (protected-access)
[pylint] varats/varats/data/databases/feature_perf_precision_database.py#L623 <212>: varats/varats/data/databases/feature_perf_precision_database.py#L623
Access to a protected member __mean_minor_page_faults of a client class (protected-access)
[pylint] varats/varats/data/databases/feature_perf_precision_database.py#L635 <212>: varats/varats/data/databases/feature_perf_precision_database.py#L635
Access to a protected member __mean_fs_outputs of a client class (protected-access)