Implements feature based perf instrumentation comparision #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added patch_name parameter to report file creation utility functions
vulder
commented
Nov 27, 2023
boehmseb
requested changes
Jan 24, 2024
varats/varats/data/databases/feature_perf_precision_database.py
Outdated
Show resolved
Hide resolved
varats/varats/data/databases/feature_perf_precision_database.py
Outdated
Show resolved
Hide resolved
varats/varats/data/databases/feature_perf_precision_database.py
Outdated
Show resolved
Hide resolved
|
|
||
| if not project.name.startswith( | ||
| "SynthIP" | ||
| ) and project.name != "SynthSAFieldSensitivity": |
There was a problem hiding this comment.
It's annoying that we have to break the abstraction between projects and experiments here (and also later in the tables). But I also don't have a good practical idea how to avoid this...
There was a problem hiding this comment.
I could not avoid this for all cases, some I got removed but depending on what one wants, it's difficult.
Co-authored-by: Sebastian Böhm <[email protected]>
boehmseb
approved these changes
Jan 25, 2024
LuAbelt
reviewed
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.