Skip to content

Implements feature based perf instrumentation comparision #2922

Implements feature based perf instrumentation comparision

Implements feature based perf instrumentation comparision #2922

Triggered via pull request September 24, 2023 08:26
Status Success
Total duration 6m 4s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

reviewdog.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

81 errors and 41 warnings
[mypy] varats-core/varats/report/tef_report.py#L72: varats-core/varats/report/tef_report.py#L72
error: Attribute "__uuid" already defined on line 70 [no-redef]
[mypy] varats-core/varats/report/tef_report.py#L75: varats-core/varats/report/tef_report.py#L75
error: Attribute "__uuid" already defined on line 70 [no-redef]
[mypy] varats-core/varats/report/tef_report.py#L188: varats-core/varats/report/tef_report.py#L188
error: Function is missing a return type annotation [no-untyped-def]
[mypy] varats-core/varats/report/tef_report.py#L188: varats-core/varats/report/tef_report.py#L188
note: Use "-> None" if function does not return a value
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L58: varats/varats/experiments/vara/feature_perf_precision.py#L58
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L100: varats/varats/experiments/vara/feature_perf_precision.py#L100
error: Argument 2 to "__init__" of "MultiPatchReport" has incompatible type "type[PerfInfluenceTraceReportAggregate]"; expected "type[TEFReportAggregate]" [arg-type]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L111: varats/varats/experiments/vara/feature_perf_precision.py#L111
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L170: varats/varats/experiments/vara/feature_perf_precision.py#L170
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L281: varats/varats/experiments/vara/feature_perf_precision.py#L281
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L372: varats/varats/experiments/vara/feature_perf_precision.py#L372
error: Non-overlapping identity check (left operand type: "str", right operand type: "Literal[ProjectDomains.TEST]") [comparison-overlap]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L424: varats/varats/experiments/vara/feature_perf_precision.py#L424
error: Call to untyped function "RevertPatch" in typed context [no-untyped-call]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L545: varats/varats/experiments/vara/feature_perf_precision.py#L545
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L665: varats/varats/experiments/vara/feature_perf_precision.py#L665
error: Call to untyped function "RevertPatch" in typed context [no-untyped-call]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L700: varats/varats/experiments/vara/feature_perf_precision.py#L700
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L765: varats/varats/experiments/vara/feature_perf_precision.py#L765
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L851: varats/varats/experiments/vara/feature_perf_precision.py#L851
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L923: varats/varats/experiments/vara/feature_perf_precision.py#L923
error: Non-overlapping identity check (left operand type: "str", right operand type: "Literal[ProjectDomains.TEST]") [comparison-overlap]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L1073: varats/varats/experiments/vara/feature_perf_precision.py#L1073
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/data/databases/feature_perf_precision_database.py#L181: varats/varats/data/databases/feature_perf_precision_database.py#L181
error: Module "varats.experiments.vara.feature_perf_precision" does not explicitly export attribute "MultiPatchReport" [attr-defined]
[mypy] varats/varats/data/databases/feature_perf_precision_database.py#L235: varats/varats/data/databases/feature_perf_precision_database.py#L235
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/data/databases/feature_perf_precision_database.py#L258: varats/varats/data/databases/feature_perf_precision_database.py#L258
error: Module "varats.experiments.vara.feature_perf_precision" does not explicitly export attribute "MultiPatchReport" [attr-defined]
[mypy] varats/varats/data/databases/feature_perf_precision_database.py#L259: varats/varats/data/databases/feature_perf_precision_database.py#L259
error: Module "varats.experiments.vara.feature_perf_precision" does not explicitly export attribute "PerfInfluenceTraceReportAggregate" [attr-defined]
[mypy] varats/varats/data/databases/feature_perf_precision_database.py#L316: varats/varats/data/databases/feature_perf_precision_database.py#L316
error: Module "varats.experiments.vara.feature_perf_precision" does not explicitly export attribute "MultiPatchReport" [attr-defined]
[mypy] varats/varats/data/databases/feature_perf_precision_database.py#L450: varats/varats/data/databases/feature_perf_precision_database.py#L450
error: Module "varats.experiments.vara.feature_perf_precision" does not explicitly export attribute "TimeReportAggregate" [attr-defined]
[mypy] varats/varats/data/databases/feature_perf_precision_database.py#L453: varats/varats/data/databases/feature_perf_precision_database.py#L453
error: Signature of "is_regression" incompatible with supertype "Profiler" [override]
[mypy] varats/varats/data/databases/feature_perf_precision_database.py#L453: varats/varats/data/databases/feature_perf_precision_database.py#L453
note: def is_regression(self, report_path: ReportFilepath, patch_name: str) -> bool
[mypy] varats/varats/data/databases/feature_perf_precision_database.py#L499: varats/varats/data/databases/feature_perf_precision_database.py#L499
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/data/databases/feature_perf_precision_database.py#L642: varats/varats/data/databases/feature_perf_precision_database.py#L642
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/data/databases/feature_perf_precision_database.py#L699: varats/varats/data/databases/feature_perf_precision_database.py#L699
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/tables/feature_perf_precision.py#L33: varats/varats/tables/feature_perf_precision.py#L33
error: Module "varats.utils.git_util" does not explicitly export attribute "git" [attr-defined]
[mypy] varats/varats/tables/feature_perf_precision.py#L213: varats/varats/tables/feature_perf_precision.py#L213
error: "OverheadData" has no attribute "mean_ctx" [attr-defined]
[mypy] varats/varats/tables/feature_perf_precision.py#L224: varats/varats/tables/feature_perf_precision.py#L224
error: "OverheadData" has no attribute "config_wise_ctx_diff"; maybe "config_wise_time_diff", "config_wise_memory_diff", or "config_wise_fs_inputs_diff"? [attr-defined]
[mypy] varats/varats/plots/feature_perf_precision.py#L301: varats/varats/plots/feature_perf_precision.py#L301
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/plots/feature_perf_precision.py#L317: varats/varats/plots/feature_perf_precision.py#L317
error: Name "text_obj" already defined on line 316 [no-redef]
[mypy] varats/varats/plots/feature_perf_precision.py#L358: varats/varats/plots/feature_perf_precision.py#L358
error: Call to untyped function "plot_pareto_frontier" in typed context [no-untyped-call]
[mypy] varats/varats/plots/feature_perf_precision.py#L404: varats/varats/plots/feature_perf_precision.py#L404
error: Function is missing a type annotation [no-untyped-def]
[pylint] varats/varats/plots/feature_perf_precision.py#L29 <116>: varats/varats/plots/feature_perf_precision.py#L29
Missing function or method docstring (missing-function-docstring)
[pylint] varats/varats/plots/feature_perf_precision.py#L301 <116>: varats/varats/plots/feature_perf_precision.py#L301
Missing function or method docstring (missing-function-docstring)
[pylint] varats/varats/plots/feature_perf_precision.py#L404 <103>: varats/varats/plots/feature_perf_precision.py#L404
Argument name "Xs" doesn't conform to snake_case naming style (invalid-name)
[pylint] varats/varats/plots/feature_perf_precision.py#L404 <103>: varats/varats/plots/feature_perf_precision.py#L404
Argument name "Ys" doesn't conform to snake_case naming style (invalid-name)
[pylint] varats/varats/plots/feature_perf_precision.py#L404 <103>: varats/varats/plots/feature_perf_precision.py#L404
Argument name "maxX" doesn't conform to snake_case naming style (invalid-name)
[pylint] varats/varats/plots/feature_perf_precision.py#L404 <103>: varats/varats/plots/feature_perf_precision.py#L404
Argument name "maxY" doesn't conform to snake_case naming style (invalid-name)
[pylint] varats/varats/tables/feature_perf_precision.py#L213 <1101>: varats/varats/tables/feature_perf_precision.py#L213
Instance of 'OverheadData' has no 'mean_ctx' member (no-member)
[pylint] varats/varats/tables/feature_perf_precision.py#L224 <1101>: varats/varats/tables/feature_perf_precision.py#L224
Instance of 'OverheadData' has no 'config_wise_ctx_diff' member (no-member)
[pylint] varats/varats/plots/feature_perf_precision.py#L23 <611>: varats/varats/plots/feature_perf_precision.py#L23
Unused PlotConfig imported from varats.plot.plots (unused-import)
[pylint] varats/varats/tables/feature_perf_precision.py#L26 <611>: varats/varats/tables/feature_perf_precision.py#L26
Unused CaseStudy imported from varats.paper.case_study (unused-import)
[pylint] varats/varats/containers/containers.py#L45 <238>: varats/varats/containers/containers.py#L45
Unused private member `ImageBase.__version_number` (unused-private-member)
[pylint] varats/varats/data/databases/feature_perf_precision_database.py#L453 <221>: varats/varats/data/databases/feature_perf_precision_database.py#L453
Number of parameters was 3 in 'Profiler.is_regression' and is now 2 in overriding 'Baseline.is_regression' method (arguments-differ)
[pylint] varats/varats/data/databases/feature_perf_precision_database.py#L544 <212>: varats/varats/data/databases/feature_perf_precision_database.py#L544
Access to a protected member __mean_major_page_faults of a client class (protected-access)
[pylint] varats/varats/data/databases/feature_perf_precision_database.py#L551 <212>: varats/varats/data/databases/feature_perf_precision_database.py#L551
Access to a protected member __mean_minor_page_faults of a client class (protected-access)
[pylint] varats/varats/data/databases/feature_perf_precision_database.py#L563 <212>: varats/varats/data/databases/feature_perf_precision_database.py#L563
Access to a protected member __mean_fs_outputs of a client class (protected-access)
[pylint] varats/varats/experiments/vara/feature_perf_precision.py#L98 <511>: varats/varats/experiments/vara/feature_perf_precision.py#L98
TODO: clean up report handling, we currently parse it as a TEFReport (fixme)
[pylint] varats/varats/experiments/vara/feature_perf_precision.py#L111 <246>: varats/varats/experiments/vara/feature_perf_precision.py#L111
Useless parent or super() delegation in method '__init__' (useless-parent-delegation)
[pylint] varats/varats/experiments/vara/feature_perf_precision.py#L170 <246>: varats/varats/experiments/vara/feature_perf_precision.py#L170
Useless parent or super() delegation in method '__init__' (useless-parent-delegation)
[pylint] varats/varats/experiments/vara/feature_perf_precision.py#L281 <246>: varats/varats/experiments/vara/feature_perf_precision.py#L281
Useless parent or super() delegation in method '__init__' (useless-parent-delegation)
[pylint] varats/varats/experiments/vara/feature_perf_precision.py#L19 <611>: varats/varats/experiments/vara/feature_perf_precision.py#L19
Unused get_base_image imported from varats.containers.containers (unused-import)
[pylint] varats/varats/experiments/vara/feature_perf_precision.py#L19 <611>: varats/varats/experiments/vara/feature_perf_precision.py#L19
Unused ImageBase imported from varats.containers.containers (unused-import)
reviewdog
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-python@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/