Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure HMA diagnostic report is 1.0 for integer primary/foreign key with very large values #2314

Merged
merged 6 commits into from
Dec 16, 2024

Conversation

fealho
Copy link
Member

@fealho fealho commented Dec 5, 2024

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.58%. Comparing base (47bc8d4) to head (0f24429).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2314   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files          58       58           
  Lines        6078     6085    +7     
=======================================
+ Hits         5992     5999    +7     
  Misses         86       86           
Flag Coverage Δ
integration 82.28% <66.66%> (+0.03%) ⬆️
unit 97.41% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fealho fealho force-pushed the issue-enterprise-919 branch 2 times, most recently from bc1330b to 6e7a7f5 Compare December 6, 2024 07:35
@fealho fealho force-pushed the issue-enterprise-919 branch from 6e7a7f5 to 9ee8ce5 Compare December 6, 2024 07:52
@fealho fealho marked this pull request as ready for review December 6, 2024 15:24
@fealho fealho requested a review from a team as a code owner December 6, 2024 15:24
@fealho fealho requested review from gsheni and removed request for a team December 6, 2024 15:24
@fealho fealho requested a review from R-Palazzo December 6, 2024 15:24
@amontanez24 amontanez24 added this to the 1.17.3 milestone Dec 11, 2024
@fealho fealho force-pushed the issue-enterprise-919 branch from b72cc94 to 932ac68 Compare December 13, 2024 18:01
@fealho fealho force-pushed the issue-enterprise-919 branch from ecc6035 to 5433441 Compare December 16, 2024 11:09
@fealho fealho force-pushed the issue-enterprise-919 branch from 5433441 to ee17238 Compare December 16, 2024 12:02
Copy link
Contributor

@R-Palazzo R-Palazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fealho fealho merged commit fceac08 into main Dec 16, 2024
41 checks passed
@fealho fealho deleted the issue-enterprise-919 branch December 16, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants