Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove S6 settings which are no longer necessary / startup service improvements #166

Closed
wants to merge 6 commits into from
Closed

remove S6 settings which are no longer necessary / startup service improvements #166

wants to merge 6 commits into from

Commits on Mar 20, 2024

  1. remove S6 settings which are no longer necessary 

    S6_BEHAVIOUR_IF_STAGE2_FAILS only affects v2 legacy services and init
scripts, thus it has no effect on the current code

S6_SERVICES_GRACETIME only applies to v2 legacy services and does not
apply to the current code

S6_KILL_GRACETIME (default 3000 milliseconds)
After all services are stopped, SIGTERM is sent to all remaining processes.
s6 then waits S6_KILL_GRACETIME and sends SIGKILL to all remaining
processes.
This gracetime is never skipped even if there are no remaining
processes.
After services are stopped, no processes should be remaining if the
services are started correctly, which is currently the case for this
container.
readsb / collectd now stop correctly as part of the services being stopped
and don't need this anymore to stop cleanly
    @wiedehopf
    wiedehopf committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    7445e1f View commit details
    Browse the repository at this point in the history

  2. fix color timezone env var warning

    @wiedehopf
    wiedehopf committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    0efc72c View commit details
    Browse the repository at this point in the history

  3. startup.d: don't prepend the whole path, just the script name

    @wiedehopf
    wiedehopf committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    06b3233 View commit details
    Browse the repository at this point in the history

  4. startup.d: start after legacy cont-init.d 

    properly define startup sequence by having startup.d depend on the base
bundle (s6 v3 recommended way of enforcing that ordering)
    @wiedehopf
    wiedehopf committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    b04b015 View commit details
    Browse the repository at this point in the history

  5. startup service: run scripts in /etc/s6-overlay/finish.d as down action

    @wiedehopf
    wiedehopf committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    b0b7f6f View commit details
    Browse the repository at this point in the history

  6. fix undefined behaviour when cd fails

    @wiedehopf
    wiedehopf committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    ad7f487 View commit details
    Browse the repository at this point in the history