remove S6 settings which are no longer necessary / startup service improvements #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S6_BEHAVIOUR_IF_STAGE2_FAILS only affects v2 legacy services and init scripts, thus it has no effect on the current code S6_SERVICES_GRACETIME only applies to v2 legacy services and does not apply to the current code S6_KILL_GRACETIME (default 3000 milliseconds) After all services are stopped, SIGTERM is sent to all remaining processes. s6 then waits S6_KILL_GRACETIME and sends SIGKILL to all remaining processes. This gracetime is never skipped even if there are no remaining processes. After services are stopped, no processes should be remaining if the services are started correctly, which is currently the case for this container. readsb / collectd now stop correctly as part of the services being stopped and don't need this anymore to stop cleanly
properly define startup sequence by having startup.d depend on the base bundle (s6 v3 recommended way of enforcing that ordering)
|
Need to fix something else .. will re-do that PR once the issue is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some S6 settings for this container are changed from the default, this is no longer necessary, so remove them. This means the container will exit on its own instead of running into the usual 10 second timeout of docker stop / compose down / compose up.
Simple fix for the timezone environment variable warning. (color code printed instead of colored warning)
startup service: