[WIP] Add offset query #150
Conversation
|
@scullxbones I have the migration on mongo shell script. What is the preferred way to deal with this changes? Doing a migration on the fly when the plugin is initialized? or offline? We have this already in production, and we have run the migration after the service was already running. Ideally, you should run a couple of time before being able to use the query with the offset to make sure all the events have the timestamp field populated. We are very keen to see this merged, we all the modification you would like to make. I will need to revert the version, but in the meantime would be good if you can give me an initial feedback. |
|
Thanks @filosganga - will take a look at it! In the past have done an online migration process, and there is also the tools subproject that could be a good place to collect migrations. Currently that's where the suffixed collection migration is run from. |
|
I didn't much like the online forced data model upgrade process, but due to breaking backward compatibility it wasn't much of an option. Given that this can run quietly in the background, and is backward compatible, that would be much better. I think it would be good to provide a Haven't had a chance to look deeply but scanning through the code looked good so far. I'd prefer to not have to see code re-formatting edits next to code edits, when possible - but that was only in a few spots. I hope to be able to dedicate some time to this tonight. |
|
Thanks @scullxbones I will provide the migration js in the tools project and also remove our specific version. |
|
Seems like tests are failing even locally - are you seeing the same? |
|
@scullxbones I made a mistake in this PR. I will fix the tests as soon as I can. |
|
Closed as I have no more time working at that |
This PR aim to fix the #95 adding the timestamp field to the journal allowing to query events by offset.
The data need a migration to populate the field from the ObjectId.