Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#148: update to akka 2.5.1 #149

Merged
merged 2 commits into from
May 22, 2017
Merged

#148: update to akka 2.5.1 #149

merged 2 commits into from
May 22, 2017

Conversation

thjaeckle
Copy link
Contributor

Pull request for #148

  • updated to Akka 2.5.1
  • used akka-persistence-query (dropped the -experimental)
  • adjusted naming of "AllPersistenceIds" to "PersistenceIds" (renamed in final akka-persistence-query)

I'm not so used in making pull requests, if I can improve something, please let me know :)

@thjaeckle
Copy link
Contributor Author

Oh, I just saw that RxMongoDriver seems to have a problem with Akka 2.5
I just verified it for Cashbah driver.

@scullxbones
Copy link
Owner

Ah ok. Will need to wait on RxMongo support then before resolving this one. Hopefully they're close.

@thjaeckle
Copy link
Contributor Author

ReactiveMongo 0.12.3 is compatible with Akka 2.5.1 - I will adjust in PR this evening.
If you want to change before, go ahead :)

@thjaeckle
Copy link
Contributor Author

Should build now but the travis build only successfully built half of the diffent configurations with success?!

@scullxbones
Copy link
Owner

I was able to get it to build via re-running failed jobs. I'd like to sequence #150 before this one for those that are still on 2.4.x series and not ready to upgrade yet.

@thjaeckle
Copy link
Contributor Author

Great.
Sure, I would do it the same way.

@thjaeckle
Copy link
Contributor Author

Are there updates on the other issue?
If this would be delayed a lot there is still the option to merge the other issue to both, an akka 2.4 branch and an akka 2.5 one and release it for both major akka-persistence-mongo versions.

@scullxbones
Copy link
Owner

@thjaeckle - that could work, yes. If #150 doesn't get resolved by Sunday evening - i'll go with that approach. I think @filosganga has a 2.4.x solution for his team anyways - so probably not a hardship for the current users of the functionality.

@scullxbones scullxbones merged commit 68b1425 into scullxbones:master May 22, 2017
@thjaeckle thjaeckle deleted the issue-148-akka-25-support branch May 22, 2017 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants