Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mtu: add clarifications #65

Merged
merged 10 commits into from
Oct 3, 2024
Merged

mtu: add clarifications #65

merged 10 commits into from
Oct 3, 2024

Conversation

jiceatscion
Copy link
Contributor

Fixes #39

@nicorusti nicorusti mentioned this pull request Sep 24, 2024
Closed
nicorusti
nicorusti reviewed Oct 3, 2024
View reviewed changes
Copy link
Member

@nicorusti nicorusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I proposed some changes.

Also, would the # Fragmentation section be a better fit after the MTU section? I feel the MTU section has a lot of explanations that can provide more background for fragmentation

draft-dekater-scion-dataplane.md Outdated Show resolved Hide resolved
draft-dekater-scion-dataplane.md Outdated Show resolved Hide resolved
draft-dekater-scion-dataplane.md Outdated Show resolved Hide resolved
draft-dekater-scion-dataplane.md Outdated Show resolved Hide resolved
@jiceatscion
Copy link
Contributor Author

jiceatscion commented Oct 3, 2024 •
edited
Loading

I proposed some changes.

Also, would the # Fragmentation section be a better fit after the MTU section? I feel the MTU section has a lot of explanations that can provide more background for fragmentation

Done.

nicorusti
nicorusti approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@nicorusti nicorusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the small doubt above, LGTM :) Thanks!

draft-dekater-scion-dataplane.md Show resolved Hide resolved
@jiceatscion jiceatscion merged commit ab0bf8c into main Oct 3, 2024
2 checks passed
@jiceatscion jiceatscion deleted the dp_mtu branch October 3, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicorusti nicorusti nicorusti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add discussion about MTU & fragmentation
2 participants
@jiceatscion @nicorusti