-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anapaya review #50
Comments
Where does this number come from. Most typically it is 3days, and in some very special cases we have 5 days. |
Where does this number come from? |
This comes from 297e8d2 @jiceatscion do you have more background? @oncilla you're right, in the PKI draft we write I see two action items:
|
The comes from the first version of the draft: b652927
It comes from the initial version of the draft: @jiceatscion I'd skim through #46 that has some considerations from ETH on beaconing |
These numbers aren't described as recommended values, but as recommended maxima. It came from some back-of-the-envelope calculations made by Matthias and used as worst-case examples in the scalability/Intra-ISD Beaconing section. The code says the default is 20, but then, that isn't a recommended value, just a mechanical place holder: it is 20 even for a core AS (if I managed to follow the code), which, wouldn't be such a good idea, would it? I'll try and clarify that notion in the text. |
I have no recollection. In all likeliness I was looking for the maximum range ever used and someone must have mentioned the existence the 5y case. If that is such an outlier, I can change the text to emphasize what the reasonable range is. |
As usual, I can take a Jesuitic approach and make a distinction between common and recommended. That way we leave the pki draft and its recommendation of 3 days alone. In the cp draft I will made the same recommendation and mention 5 days as an outlier. Let's forget the 5y. |
Following the first wave of ISE feedback, we did quite some work, especially on the control plane draft:
Please review (sorted by urgency):
Other pointers:
@shitz @oncilla @sgmonroy could one of you have a look at the overall changes and provide some feedback? If you feel, you can directly open a PR. We are planning to have a new submission when datatracker reopens on 21.07, before our panrg session to address #48 , and it would be great if we could also incorporate some of your feedback.
The text was updated successfully, but these errors were encountered: