Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: set output AudioBitRate #12

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Fix: set output AudioBitRate #12

merged 1 commit into from
Jan 22, 2024

Conversation

xage93
Copy link
Contributor

@xage93 xage93 commented Jan 17, 2024 •
edited
Loading

This PR fixes the issue with the AudioBitRate function. It was setting the output audioRate instead of audioBitrate.

@xage93 xage93 mentioned this pull request Jan 17, 2024
Closed
CryogenicPlanet
CryogenicPlanet approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@CryogenicPlanet CryogenicPlanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested this but looks good -> checked node-fluent-ffmpeg and had something similar, overall looks fine

@CryogenicPlanet CryogenicPlanet merged commit 7450039 into scalarhq:master Jan 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CryogenicPlanet CryogenicPlanet CryogenicPlanet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xage93 @CryogenicPlanet