Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting output Audio Bitrate sets the Audio Rate instead #13

Closed
xage93 opened this issue Jan 17, 2024 · 4 comments
Closed

Setting output Audio Bitrate sets the Audio Rate instead #13

xage93 opened this issue Jan 17, 2024 · 4 comments

Comments

@xage93
Copy link
Contributor

xage93 commented Jan 17, 2024

I found an issue when trying to set the output audioBitrate. The function AudioBitRate is doing the same thing as the AudioRate function which is setting the .audioRate property instead of .audioBitrate.

I've forked the repo and fixed the issue in this PR: #12
@xage93 xage93 mentioned this issue Jan 17, 2024
Merged
@xage93
Copy link
Contributor Author

xage93 commented Jan 19, 2024

Hey folks.

@zackradisic @CryogenicPlanet @david74chou

Hoping to get a few minutes of your time to have a look at this. Would be nice if we could drive this forward. Sort of relying on this package in one of our services.

@xage93
Copy link
Contributor Author

xage93 commented Jan 19, 2024

Gentle bump here

@xage93
Copy link
Contributor Author

xage93 commented Jan 22, 2024

Bump here @zackradisic @CryogenicPlanet @david74chou

@xage93
Copy link
Contributor Author

xage93 commented Jan 22, 2024

Closing the issue as it's been fixed by merging this PR. Thanks guys!

@xage93 xage93 closed this as completed Jan 22, 2024
@xage93 xage93 mentioned this issue Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xage93