Fix: get audioBitrate instead of audioRate #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures we get audio bitrate instead of audio rate in output_getters file. Fixes the same issue as the one fixed here for output_setters.
Test Proof
Code being tested:
Screenshots of the code to test and the output. Basically set the output bitrate and sample rate to 64000 and 22000 respectively.
Then fetched the same and printed out. Shows the correct settings.
Before Changes - (using current release v0.1.0)
You can see that it's only setting the
audioRate
and then gettingaudioRate
as well because both setter and getter useaudioRate
instead ofaudioBitrate
.After Changes
While I fixed the setter in the other PR (#13), this PR fixes the getter as well.