-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sbb-checkbox, sbb-radio-button): split into regular and panel variants #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarioCastigliano
added
pr: peer review required
A peer review is required for this pull request
pr: lead review required
A lead review is required for this pull request
labels
Apr 5, 2024
MarioCastigliano
requested review from
kyubisation and
jeripeierSBB
as code owners
April 5, 2024 08:38
MarioCastigliano
requested review from
DavideMininni-Fincons,
kyubisation and
jeripeierSBB
and removed request for
kyubisation and
jeripeierSBB
April 5, 2024 08:38
MarioCastigliano
force-pushed
the
refactor/split-panel-components
branch
from
April 9, 2024 09:01
3c9b9a0
to
e88dab8
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2552 +/- ##
==========================================
- Coverage 93.18% 93.13% -0.06%
==========================================
Files 316 315 -1
Lines 25389 24804 -585
Branches 2063 2013 -50
==========================================
- Hits 23660 23100 -560
+ Misses 1696 1671 -25
Partials 33 33 ☔ View full report in Codecov by Sentry. |
# Conflicts: # src/elements/radio-button/radio-button-group/radio-button-group.spec.ts # src/elements/selection-expansion-panel/selection-expansion-panel.spec.ts
github-actions
bot
added
pr: visual review required
and removed
pr: visual review required
labels
Jun 14, 2024
jeripeierSBB
force-pushed
the
refactor/split-panel-components
branch
from
June 14, 2024 06:12
2fc01d0
to
4302823
Compare
github-actions
bot
added
pr: visual review required
and removed
pr: visual review required
labels
Jun 14, 2024
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
diff-available
pr: lead review approved
Pull request has been approved by a lead review
pr: peer review approved
Pull request has been approved by a peer review
pr: visual review required
preview-available
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2395
BREAKING CHANGE:
sbb-selection-panel
has been renamed tosbb-selection-expansion-panel
. Thesbb-checkbox
andsbb-radio-button
components cannot be used anymore withsbb-selection-expansion-panel
(does not apply for cases where they are slotted inside thecontent
slot). As a replacement, we introduce the new componentssbb-checkbox-panel
andsbb-radio-button-panel
, which could also be used standalone in cases where there is no content.sbb-checkbox-group
andsbb-radio-button-group
also support the panel variants.How to migrate?
sbb-selection-panel
tosbb-selection-expansion-panel
.sbb-selection-expansion-panel
, replacesbb-checkbox
withsbb-checkbox-panel
andsbb-radio-button
withsbb-radio-button-panel
(does not apply for cases where they are slotted inside thecontent
slot of thesbb-selection-expansion-panel
)sbb-selection-panel
/sbb-selection-expansion-panel
anymore, but directly usesbb-checkbox-panel
orsbb-radio-button-panel
.