Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbb-checkbox, sbb-radio-button): split into regular and panel variants #2552

Merged
merged 109 commits into from
Jun 14, 2024

Conversation

MarioCastigliano
Copy link
Contributor

@MarioCastigliano MarioCastigliano commented Apr 5, 2024

Closes #2395

BREAKING CHANGE: sbb-selection-panel has been renamed to sbb-selection-expansion-panel. The sbb-checkbox and sbb-radio-button components cannot be used anymore with sbb-selection-expansion-panel (does not apply for cases where they are slotted inside the content slot). As a replacement, we introduce the new components sbb-checkbox-panel and sbb-radio-button-panel, which could also be used standalone in cases where there is no content. sbb-checkbox-group and sbb-radio-button-group also support the panel variants.
How to migrate?

  • Rename usages of sbb-selection-panel to sbb-selection-expansion-panel.
  • Inside the sbb-selection-expansion-panel, replace sbb-checkbox with sbb-checkbox-panel and sbb-radio-button with sbb-radio-button-panel (does not apply for cases where they are slotted inside the content slot of the sbb-selection-expansion-panel)
  • In cases where there was no content (slot), don't use sbb-selection-panel/sbb-selection-expansion-panel anymore, but directly use sbb-checkbox-panel or sbb-radio-button-panel.

@MarioCastigliano MarioCastigliano self-assigned this Apr 5, 2024
@MarioCastigliano MarioCastigliano added pr: peer review required A peer review is required for this pull request pr: lead review required A lead review is required for this pull request labels Apr 5, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2552 April 5, 2024 08:38 Inactive
@MarioCastigliano MarioCastigliano marked this pull request as ready for review April 5, 2024 08:38
@MarioCastigliano MarioCastigliano force-pushed the refactor/split-panel-components branch from 3c9b9a0 to e88dab8 Compare April 9, 2024 09:01
@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 93.15068% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 93.13%. Comparing base (e6397df) to head (f397699).
Report is 52 commits behind head on main.

Files Patch % Lines
...io-button/radio-button-group/radio-button-group.ts 81.81% 4 Missing ⚠️
...mponents/checkbox/checkbox-group/checkbox-group.ts 94.44% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2552      +/-   ##
==========================================
- Coverage   93.18%   93.13%   -0.06%     
==========================================
  Files         316      315       -1     
  Lines       25389    24804     -585     
  Branches     2063     2013      -50     
==========================================
- Hits        23660    23100     -560     
+ Misses       1696     1671      -25     
  Partials       33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to preview-pr2552 April 9, 2024 10:47 Inactive
@github-actions github-actions bot temporarily deployed to pr2552 June 13, 2024 19:05 Inactive
@github-actions github-actions bot temporarily deployed to pr2552 June 13, 2024 21:40 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review approved Pull request has been approved by a peer review pr: visual review required preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate checkbox and radio buttons into base components and panel components
5 participants