refactor(sbb-selection-panel, sbb-checkbox, sbb-radio-button): split into regular and panel variants #2778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into regular and panel variants Closes #2395 BREAKING CHANGE: `sbb-selection-panel` has been renamed to `sbb-selection-expansion-panel`. The `sbb-checkbox` and `sbb-radio-button` components cannot be used anymore with `sbb-selection-expansion-panel` (does not apply for cases where they are slotted inside the `content` slot). As a replacement, we introduce the new components `sbb-checkbox-panel` and `sbb-radio-button-panel`, which could also be used standalone in cases where there is no content. `sbb-checkbox-group` and `sbb-radio-button-group` also support the panel variants. How to migrate? - Rename usages of `sbb-selection-panel` to `sbb-selection-expansion-panel`. - Inside the `sbb-selection-expansion-panel`, replace `sbb-checkbox` with `sbb-checkbox-panel` and `sbb-radio-button` with `sbb-radio-button-panel` (does not apply for cases where they are slotted inside the `content` slot of the `sbb-selection-expansion-panel`) - In cases where there was no content (slot), don't use `sbb-selection-panel`/`sbb-selection-expansion-panel` anymore, but directly use `sbb-checkbox-panel` or `sbb-radio-button-panel`. --------- Co-authored-by: Davide Mininni <[email protected]> Co-authored-by: Jeremias Peier <[email protected]>
github-actions
bot
added
the
pr: peer review required
github-actions
bot
added
preview-available
pr: visual review required
diff-available
labels
github-actions
bot
removed
the
pr: peer review required
This was referenced Jun 14, 2024
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2395
BREAKING CHANGE:
sbb-selection-panelhas been renamed tosbb-selection-expansion-panel. Thesbb-checkboxandsbb-radio-buttoncomponents cannot be used anymore withsbb-selection-expansion-panel(does not apply for cases where they are slotted inside thecontentslot). As a replacement, we introduce the new componentssbb-checkbox-panelandsbb-radio-button-panel, which could also be used standalone in cases where there is no content.sbb-checkbox-groupandsbb-radio-button-groupalso support the panel variants. How to migrate?sbb-selection-paneltosbb-selection-expansion-panel.sbb-selection-expansion-panel, replacesbb-checkboxwithsbb-checkbox-panelandsbb-radio-buttonwithsbb-radio-button-panel(does not apply for cases where they are slotted inside thecontentslot of thesbb-selection-expansion-panel)sbb-selection-panel/sbb-selection-expansion-panelanymore, but directly usesbb-checkbox-panelorsbb-radio-button-panel.Originally #2552, which needed to be reverted and now re-applied.