Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sbb-image): lit migration #2029

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Conversation

dauriamarco
Copy link
Contributor

Migrate sbb-image to Lit.

@dauriamarco dauriamarco self-assigned this Sep 29, 2023
@github-actions github-actions bot temporarily deployed to preview-pr2029 September 29, 2023 14:19 Inactive
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, just a couple of suggestions

src/components/sbb-image/sbb-image.e2e.ts Outdated Show resolved Hide resolved
src/components/sbb-image/sbb-image.tsx Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (lit-migration@b00745a). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@               Coverage Diff                @@
##             lit-migration    #2029   +/-   ##
================================================
  Coverage                 ?   88.88%           
================================================
  Files                    ?       91           
  Lines                    ?     9875           
  Branches                 ?      408           
================================================
  Hits                     ?     8777           
  Misses                   ?     1094           
  Partials                 ?        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dauriamarco dauriamarco merged commit 8d915b8 into lit-migration Oct 2, 2023
10 checks passed
@dauriamarco dauriamarco deleted the migr/sbb-image branch October 2, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants