fix: review

sbb-design-systems · Oct 2, 2023 · 1e3510c · 1e3510c
1 parent 542717d
commit 1e3510c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/src/components/sbb-image/sbb-image.e2e.ts b/src/components/sbb-image/sbb-image.e2e.ts
@@ -15,7 +15,6 @@ describe('sbb-image', () => {
     // Wait five seconds in hope the image will successfully be loaded
     // TODO: Find more reliable solution
     await new Promise((res) => setTimeout(res, 2000));
-    await element.updateComplete;
 
     expect(element).dom.to.be.equal(`
       <sbb-image image-src="${url}"></sbb-image>

diff --git a/src/components/sbb-image/sbb-image.tsx b/src/components/sbb-image/sbb-image.tsx
@@ -455,7 +455,7 @@ export class SbbImage extends LitElement {
               ];
             })}
             <img
-              alt=${this.alt}
+              alt=${this.alt || nothing}
               class="image__img"
               src=${this.imageSrc}
               width="1000"