Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add tests for enhanced routing control #143

Merged
merged 36 commits into from
Oct 7, 2024
Merged

test: add tests for enhanced routing control #143

merged 36 commits into from
Oct 7, 2024

Conversation

polsar88
Copy link
Contributor

@polsar88 polsar88 commented Oct 6, 2024

Related PRs:

Description

This PR addresses the following outstanding comment from a previous PR: #133 (comment)

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 😎 New feature (non-breaking change which adds functionality)
  • ⁉️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ⚒️ Refactor (no functional changes)
  • 📖 Documentation (updating or adding docs)

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Staging
  • Gradual release to production

polsar88 added 26 commits October 3, 2024 15:30
@polsar88
fix: remove a TODO
366febb
@polsar88
fix: field alignment
bb4ab4b
@polsar88
fix: field alignment
36891fb
@polsar88
fix: readability
bd672bd
@polsar88
fix: update README.md
d5b839e
@polsar88
feat: initial implementation of AlwaysRouteRoutingStrategy
1d92136
@polsar88
fix: comment formatting
1193c14
@polsar88
fix: comment phrasing
6ecd34e
@polsar88
fix: add a TODO
866fc13
@polsar88
fix: renaming
1cf33a6
@polsar88
fix: revert to the previous version of PriorityRoundRobinStrategy
017c250
@polsar88
fix: remove HealthStatus field
0059f34
@polsar88
feat: LatencyChecker can now be configured to only check latency, err…
a677f46 
…ors, or both
@polsar88
feat: create separate instances of LatencyChecker for error and laten…
90846f6 
…cy checking
@polsar88
feat: plumbing for AlwaysRouteFilteringStrategy
7e2ed8e
@polsar88
fix: tests
f99e30d
@polsar88
fix: removable filters
bd234d0
@polsar88
feat: add debug logging
7ccf798
@polsar88
fix: move getFilterTypeName function to node_filter module
fe9de04
@polsar88
refactor: deduplicate filter upstreams code
84b73da
@polsar88
refactor: rebase
bd362f2
@polsar88
refactor: remove passive error/latency checker code
a0442dd
@polsar88
refactor: split error latency checker into two structs
b4ce312
@polsar88
fix: error and latency filters are now passed to regular filtering ro…
8703aac 
…uting strategy
@polsar88
fix: typo
77838f1
@polsar88
style: remove unused global variable
2f5347f
@polsar88 polsar88 changed the title Add tests for enhanced routing control test: add tests for enhanced routing control Oct 6, 2024
@polsar88 polsar88 marked this pull request as draft October 6, 2024 23:03
@polsar88 polsar88 marked this pull request as ready for review October 7, 2024 05:45
@polsar88 polsar88 requested a review from brianluong October 7, 2024 05:48
brianluong
brianluong previously approved these changes Oct 7, 2024
View reviewed changes
Base automatically changed from polsar/split-error-latency-checker to main October 7, 2024 21:09
@polsar88 polsar88 dismissed brianluong’s stale review October 7, 2024 21:09

The base branch was changed.

@polsar88 polsar88 merged commit 0c27246 into main Oct 7, 2024
5 checks passed
@polsar88 polsar88 deleted the polsar/add-tests branch October 7, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianluong brianluong brianluong left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polsar88 @brianluong