feat: improve code based on local testing #134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added instructions to `README.md` * feat: update dependencies * feat: updated dependencies * feat: new mockery version * feat: add routing config params * feat: upgrade Go version * fix: suppress legacy linter errors * fix: field alignments in structs * fix: field linter errors * fix: linter errors * feat: add routing config params * feat: validate routing error rate * feat: refactoring * feat: add a TODO * feat: `ErrorsConfig` and `LatencyConfig` are now pointers * feat: add a field to routing config test * feat: set defaults for `DetectionWindow` and `BanWindow` * feat: move RoutingConfig functions closer to the struct * feat: changed `or` to `and` * feat: split function into validation and setting defaults components * feat: settings the config defaults now mirrors the validation workflow * feat: remove redundant call
brianluong
reviewed
Sep 25, 2024
| @@ -24,6 +24,7 @@ type BlockHeightCheck struct { | |||
| logger *zap.Logger | |||
| blockHeight uint64 | |||
| useWSForBlockHeight bool | |||
| ShouldRun bool // TODO(polsar): Add config parameter to control whether this check should run. | |||
There was a problem hiding this comment.
curious what's the motivation behind this? will this set to false by default? we want to run this check for all chains/upstreams
There was a problem hiding this comment.
yes, this is temporary while testing, because the check fails on my dumb Python endpoints, marking all upstreams as unhealthy
not gonna merge this 😅
|
I will also push my Python script and test YAML later today so you can reproduce testing on your laptop |
…ing-enhancements fix: rebase
Base automatically changed from
polsar/support-always-route
to
latency-checker-wiring
September 25, 2024 21:52
Base automatically changed from
latency-checker-wiring
to
polsar/latency-checker
September 25, 2024 21:53
Base automatically changed from
polsar/latency-checker
to
polsar/config-parsing-enhancements
September 25, 2024 21:54
Base automatically changed from
polsar/config-parsing-enhancements
to
polsar/go-version-and-readme
September 25, 2024 21:55
polsar88
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.