Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add error and latency-based routing control (part 2) #128

Closed
wants to merge 69 commits into from
Closed

feat: add error and latency-based routing control (part 2) #128

wants to merge 69 commits into from

Conversation

polsar88
Copy link
Contributor

@polsar88 polsar88 commented Aug 13, 2024 •
edited
Loading

Description

Design: https://www.notion.so/alchemotion/Error-and-latency-based-routing-in-the-Satsuma-node-gateway-3a60d896c5844f82bf90f68570b00608

Tracker: https://www.notion.so/alchemotion/Project-tracker-Error-latency-based-routing-1999d7ff3e5c430d9af3a7149923d8b9

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 😎 New feature (non-breaking change which adds functionality)
  • ⁉️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ⚒️ Refactor (no functional changes)
  • 📖 Documentation (updating or adding docs)

@polsar88 polsar88 changed the base branch from main to feat/routing-enhancements August 13, 2024 21:50
@polsar88 polsar88 changed the title Polsar/routing enhancements contd feat: add config parameters for fine-grained routing control (part 2) Aug 13, 2024
@polsar88 polsar88 changed the title feat: add config parameters for fine-grained routing control (part 2) feat: add error and latency-based routing control (part 2) Aug 15, 2024
polsar88 added 23 commits August 14, 2024 18:18
@polsar88
fix: comment
339e1c9
@polsar88
fix: TODO
0cf2b4c
@polsar88
feat: add instructions on generating HTML coverage report
888ac69
@polsar88
feat: add HealthCheck method for Ethereum client
90b15e0
@polsar88
fix: rename method
3bc2508
@polsar88
feat: initial implementation of latency checker
0fcaa79
@polsar88
fix: add a TODO
62455a3
@polsar88
fix: access to failure counts map is now thread-safe
510bf97
@polsar88
fix: refactor anonymous function into runCheckForMethod method
6b8fbc1
@polsar88
fix: further refactoring
6c02c16
@polsar88
fix: refactoring
c40eb46
@polsar88
fix: formatting
6b8ee86
@polsar88
feat: wire routing configs into HealthCheckManager
54c7455
@polsar88
fix: refactoring & additional validation
c5d84e0
@polsar88
fix: add a test
faeec65
@polsar88
fix: refactoring
e2cc632
@polsar88
feat: add latency override logic
9601d2e
@polsar88
fix: add latency config tests
cc33e27
@polsar88
feat: wire RoutingConfig into LatencyChecker
af55fcf
@polsar88
fix: un-export LatencyConfig methods
e204d9f
@polsar88
fix: LatencyCheck's ShouldRun filed is now initialized based on the r…
67003be 
…outing config
@polsar88
feat: latency checks for all configured methods are now run in parallel
51445ca
@polsar88
fix: lint
4a2174f
@polsar88 polsar88 marked this pull request as ready for review August 19, 2024 04:24
brianluong
brianluong reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@brianluong brianluong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly focused on latency.go and the TODO comments!

internal/checks/slidingwindow.go Outdated Show resolved Hide resolved
internal/checks/latency.go Outdated Show resolved Hide resolved
internal/checks/latency.go Show resolved Hide resolved
internal/checks/latency.go Outdated Show resolved Hide resolved
internal/checks/latency.go Outdated Show resolved Hide resolved
internal/checks/latency.go Show resolved Hide resolved
internal/checks/slidingwindow.go Outdated Show resolved Hide resolved
internal/checks/latency.go Show resolved Hide resolved
internal/client/ethereum_client.go Outdated Show resolved Hide resolved
internal/config/config.go Show resolved Hide resolved
polsar88 added 18 commits August 27, 2024 15:40
@polsar88
fix: errors circuit breaker IsOpen method now works correctly
7c15233
@polsar88
fix: TODOs
a53a9a8
@polsar88
fix: rename methods for indicate they are only used for passive healt…
b13e997 
…h checks
@polsar88
fix: TODOs
49d13d8
@polsar88
feat: each JSON RPC subrequest now counts toward the error rate
0055b31
@polsar88
fix: rename Latency method to RecordLatency
3fe3258
@polsar88
fix: update a TODO
08b0341
@polsar88
feat: add failsafe-go package
8b97890
@polsar88
fix: an upstream can now be marked unhealthy only for the RPC methods…
2d297af 
… specified in the request
@polsar88
feat: high latency rate is now used to determine whether latency circ…
3f9684f 
…uit breaker is open
@polsar88
feat: wired alwaysRoute routing config setting to PriorityRoundRobi…
3f318d2 
…nStrategy
@polsar88
feat: add support for indicating the reason why an upstream is unhealthy
d4d421d
@polsar88
feat: routing algorithm to route to an unhealthy upstream
d399d59
@polsar88
feat: failsafe-go is now used for latency circuit breaking
b7ae0b3
@polsar88
feat: failsafe-go is now used for error circuit breaking
fd726d7
@polsar88
fix: change generic type for circuit breaker
73edd03
@polsar88
fix: remove sliding window
0e66d3a
@polsar88
fix: update comments
f3a07e7
@polsar88 polsar88 closed this Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianluong brianluong brianluong left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polsar88 @brianluong