Skip to content

Commit

Permalink
fix: updated comments
Browse files Browse the repository at this point in the history
  • Loading branch information
polsar88 committed Sep 5, 2024
1 parent b95c5df commit dc37651
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions internal/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,7 @@ const (
)

// UpstreamConfig
// TODO(polsar): Move the HealthStatus field to a new struct and embed this struct in it.
//
// Asana task: https://app.asana.com/0/1207397277805097/1208232039997185/f
// TODO(polsar): Move the HealthStatus field to a new struct and embed this struct in it. Asana task: https://app.asana.com/0/1207397277805097/1208232039997185/f
type UpstreamConfig struct {
Methods MethodsConfig `yaml:"methods"`
HealthCheckConfig HealthCheckConfig `yaml:"healthCheck"`
Expand Down Expand Up @@ -279,6 +277,8 @@ func (c *MethodConfig) isMethodConfigValid(passiveLatencyChecking bool) bool {
// TODO(polsar): Add the minimum number of latencies in the detection window required to apply the threshold.
// TODO(polsar): Add other aggregation options. Currently, the average of latencies in the detection windows is used.
type LatencyConfig struct {
// This field allows us to quickly look up the latency of a method, rather than doing so by traversing the Methods slice.
//
// TODO(polsar): Move this field to a new struct and embed this struct in it.
// Asana task: https://app.asana.com/0/1207397277805097/1208232039997185/f
MethodLatencyThresholds map[string]time.Duration
Expand Down

0 comments on commit dc37651

Please sign in to comment.